Opened 13 years ago

Closed 13 years ago

#31073 closed defect (fixed)

Checksum failure for ports that fetch using cvs/git/hg/svn

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: High Milestone: MacPorts 2.0.3
Component: base Version: 2.0.2
Keywords: Cc: ak.ml@…, raimue (Rainer Müller), hans.vonkaraman@…, rick@…
Port:

Description

With MacPorts 2.0.2, at least some ports that fetch using git fail with a checksum error. The checksum phase shouldn't even be running for ports that fetch using an scm. This is a regression from 2.0.1 which didn't have this problem.

$ sudo port extract pianobar
--->  Computing dependencies for pianobar
--->  Fetching pianobar
--->  Verifying checksum(s) for pianobar
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/pianobar
Log for pianobar is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_audio_pianobar/pianobar/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>
$ sudo port extract git-flow
--->  Computing dependencies for git-flow
--->  Fetching git-flow
--->  Verifying checksum(s) for git-flow
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/git-flow
Log for git-flow is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_devel_git-flow/git-flow/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>
$ sudo port extract yajl
--->  Computing dependencies for yajl
--->  Fetching yajl
--->  Verifying checksum(s) for yajl
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/yajl
Log for yajl is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_devel_yajl/yajl/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>
$ sudo port extract ffmpeg-devel
--->  Computing dependencies for ffmpeg-devel
--->  Fetching ffmpeg-devel
--->  Verifying checksum(s) for ffmpeg-devel
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/ffmpeg-devel
Log for ffmpeg-devel is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_multimedia_ffmpeg-devel/ffmpeg-devel/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

Curiously, other ports that fetch using git aren't affected, including:

  • libhsplasma
  • liblrdf
  • xorg-server-devel

The only change that I think happened to checksumming in 2.0.2 is r83149 (#28568).

Attachments (1)

macports-31073-mayoff-patch-1 (1.1 KB) - added by macports@… 13 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Summary: Checksum failure for ports that fetch using gitChecksum failure for ports that fetch using cvs/git/hg/svn

I also see the problem with ports using other SCMs:

  • cvs (cableswig, but not Chmox, sheepshaver or maven)
  • hg (BWToolkit and go, but not iulib or ocropus)
  • svn (couchdb-devel, iTerm, iTerm2, rgm3800 and taglib-devel, but not CronniX)

I didn't see the problem with bzr, but we only have one port with that fetch type.

Changed 13 years ago by macports@…

comment:2 Changed 13 years ago by macports@…

The problem is the default setting of distfiles, which as of r83149 creates a list even if portfetch::suffix returns an empty string. I've attached a fix.

comment:3 Changed 13 years ago by afb@…

It would be "nice" if the checksum/digest didn't change, just because one chooses a different compression or archiver or method of transportation... For instance, by using a file manifest ?

comment:4 Changed 13 years ago by kyle@…

FYI, the patch worked great here.

comment:5 Changed 13 years ago by ak.ml@…

Cc: ak.ml@… added

Cc Me!

comment:6 in reply to:  3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to afb@…:

It would be "nice" if the checksum/digest didn't change, just because one chooses a different compression or archiver or method of transportation... For instance, by using a file manifest ?

That doesn't seem relevant to this ticket.

comment:7 in reply to:  2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to jmr@…

Replying to macports@…:

The problem is the default setting of distfiles, which as of r83149 creates a list even if portfetch::suffix returns an empty string. I've attached a fix.

It looks like a fix was committed in r83471. Duplicates #31078 (qjson) and #31091 (dbusmenu-qt) have already been filed; we should release MacPorts 2.0.3 with this fix ASAP rather than fixing each port individually (as has already begun with qjson).

comment:8 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Milestone: MacPorts 2.0.3

comment:9 Changed 13 years ago by rick@…

As the submitter of ticket:31091 I agree with ryandesign@… - individual fixes are not the way to go as they will not solve the underlying problem.

If I knew how to withdraw ticket:31091 I certainly would.

comment:10 Changed 13 years ago by jmroot (Joshua Root)

Owner: changed from jmr@… to ryandesign@…

I'm on holiday at the moment.

comment:11 Changed 13 years ago by oi@…

Patch worked here also

comment:12 Changed 13 years ago by raimue (Rainer Müller)

Cc: raimue@… added

comment:13 in reply to:  11 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to oi@…:

Patch worked here also

We're not using that patch; we're using what was committed in r83471.

comment:14 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: hans.vonkaraman@… added

Has duplicate #31135.

comment:15 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: rick@… added

comment:16 in reply to:  15 ; Changed 13 years ago by rick@…

Replying to ryandesign@…:
Patch works for me

comment:17 in reply to:  16 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to rick@…:

Patch works for me

Again, we are not going to be using the patch attached to this ticket; we're using what has already been committed in r83471 and which will be released in MacPorts 2.0.3.

comment:18 Changed 13 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

MacPorts 2.0.3 has been released.

Note: See TracTickets for help on using tickets.