Opened 20 years ago

Closed 19 years ago

#3115 closed defect (fixed)

PATCH: py-opengl didn't build on Tiger.

Reported by: jsnitow@… Owned by: mww@…
Priority: Normal Milestone:
Component: ports Version: 1.0
Keywords: Cc: markd@…
Port:

Description

The latest py-opengl would not build on Tiger. I submitted the following patch to the Python patch manager (the URL has a more full description, as well):

http://sourceforge.net/tracker/index.php?func=detail&aid=1203329&group_id=5470&atid=305470

With this patch applied to the Include/pyport.h in python 2.4.1, py-opengl compiles and runs.

Until the main Python project accepts this patch (and in case they don't), I'm sending it here, too, as the patch works Right Now. :-)

Attachments (1)

pyport.h.diff (861 bytes) - added by jsnitow@… 20 years ago.
Context patch for python 2.4.1's Include/pyport.h

Download all attachments as: .zip

Change History (6)

Changed 20 years ago by jsnitow@…

Attachment: pyport.h.diff added

Context patch for python 2.4.1's Include/pyport.h

comment:1 Changed 20 years ago by mww@…

Resolution: fixed
Status: newclosed

excellent, thanks! commited;

comment:2 Changed 20 years ago by jsnitow@…

Resolution: fixed
Status: closedreopened

Upon further reflection (and see comment by loewis in the aforementioned URL), this patch IMHO should be considered a temporary workaround, and not a fix. It may be masking a real bug in the build process of either python, py-opengl (likely), or possibly py-numeric.

[py-opengl probably shouldn't even have to worry about sys/stat.h at all.]

[Note also that a dummy .c file with _POSIX_C_SOURCE undefined and sys/stat.h included compiles just fine. Something screwy must have been happening during the overall build process of py-opengl (either it was toggling the state of _POSIX_C_SOURCE, or otherwise messing with the definition of the tokens _TIMESPEC or timespec, which was causing the sys/stat.h included in pyport.h, included in the build process of py-opengl, to emit a compile error.]

In any event, py-opengl now seems to compile without this patch, so this patch should probably be removed from pyport.h, especially if it also compiles for you, sans patch.

comment:3 Changed 19 years ago by blb@…

Owner: changed from darwinports-bugs@… to mww@…
Status: reopenednew

Shooting over to the maintainer...

comment:4 Changed 19 years ago by markd@…

Cc: markd@… added

Have subsequent Python updates taken care of this? Can this bug be closed?

comment:5 Changed 19 years ago by markd@…

Resolution: fixed
Status: newclosed

This works for me and appears to be fixed. Reopen if you still experience problems.

Note: See TracTickets for help on using tickets.