Opened 13 years ago
Closed 9 years ago
#31203 closed update (fixed)
Updated ports for xfce 4.8
Reported by: | ak.ml@… | Owned by: | afb@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.0.3 |
Keywords: | xfce, haspatch | Cc: | cooljeanius (Eric Gallager) |
Port: | exo, garcon, gtk-xfce-engine, libxfce4ui, libxfce4util, libxfcegui4, orage, ristretto, Terminal, Thunar, xfce-utils, xfce4-appfinder, xfce4-panel, xfce4-session, xfce4-settings, xfconf, xfdesktop, xfwm4 |
Description
I followed the build guideline http://xfce.org/download/building#dependencies
Core components:
exo
garcon
[new]gtk-xfce-engine
libxfce4ui
[new]libxfce4util
libxfcegui4
[deprecated]Thunar
xfce-utils
xfce4-appfinder
xfce4-panel
xfce4-session
xfce4-settings
xfconf
xfdesktop
xfwm4
Applications:
orage
ristretto
Terminal
Attached:
- Combined diff of modified Portfiles, I kept the indentation as it was in hope that it would make it easier to review.
- New Portfiles for
garcon
andlibxfce4ui
- New patchfile:
xfce/libxfcegui4/files/patch-environ.diff
- Updated patchfile:
xfce/Terminal/files/patch-terminal-Makefile.in
I removed the following patchfiles:
xfce/exo/files/exo-mmintrin.diff xfce/Thunar/files/patch-configure-snow.diff xfce/Thunar/files/patch-thunar-metafile.c xfce/xfce4-panel/files/config-launcher-icons.diff xfce/xfce4-panel/files/fix-xfce-bug-6110.diff xfce/xfce4-settings/files/patch-configure.diff xfce/xfce4-settings/files/patch-workspaces.c
Remarks:
- I haven't updated
xfce
metaport but I can come up with something if you like. By the way I would refer to Xfce (which would need an update as well) for the setup instructions. I would use notes for the setup instructions. - If this gets committed, I'd appreciate if it was consistently indented, and modelines were added
- You can add me as co-maintainer
ristretto
doesn't work for me: I can't select any file for display
Attachments (6)
Change History (28)
Changed 13 years ago by ak.ml@…
Attachment: | patch-xfce-4.8.diff added |
---|
Changed 13 years ago by ak.ml@…
Attachment: | patch-environ.diff added |
---|
xfce/libxfcegui4/files/patch-environ.diff
Changed 13 years ago by ak.ml@…
Attachment: | patch-terminal-Makefile.in added |
---|
xfce/Terminal/files/patch-terminal-Makefile.in
comment:1 follow-up: 3 Changed 13 years ago by ak.ml@…
I thought I had kept the indentation as it was but didn't.
comment:2 Changed 13 years ago by afb@…
Owner: | changed from macports-tickets@… to afb@… |
---|---|
Status: | new → assigned |
comment:3 Changed 13 years ago by afb@…
I thought I had kept the indentation as it was but didn't.
It could be changed to spaces, if you're allergic to tabs.
comment:4 follow-up: 5 Changed 13 years ago by afb@…
All the ports will also need to have "license" added (for distribution), after "platforms".
comment:5 follow-up: 6 Changed 13 years ago by ak.ml@…
I wasn't aware of that when I updated the Portfiles in the first place. However I still can't tell the difference between GPL-2
and GPL-2+
comment:6 Changed 13 years ago by afb@…
Replying to ak.ml@…:
I wasn't aware of that when I updated the Portfiles in the first place. However I still can't tell the difference between
GPL-2
andGPL-2+
The only way to tell is to look at the header of the actual source code... If it says "or (at your option) any later version" it's +.
comment:7 Changed 13 years ago by ak.ml@…
Any status update?
There were several updates on the XFCE side, especially for ristretto @0.1.1
which now works.
comment:8 follow-up: 9 Changed 13 years ago by afb@…
I got side-tracked, but tabs-to-spaces and licenses were done.
comment:9 follow-up: 10 Changed 13 years ago by ak.ml@…
Replying to afb@…:
I got side-tracked, but tabs-to-spaces and licenses were done.
Thanks for the reply.
You made a lot of changes in depends_build
for the buildbot I guess.
Is this still a work in progress?
Are there other steps before you actually update to Xfce 4.8?
comment:10 Changed 13 years ago by afb@…
You made a lot of changes in
depends_build
for the buildbot I guess.
Is this still a work in progress?
There shouldn't be any more such changes needed (to 4.6), I think.
Are there other steps before you actually update to Xfce 4.8?
Nope, except that all ports must be updated at once due to deps...
comment:11 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
comment:12 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | afb@… removed |
---|
Anders, will you do this update?
comment:13 Changed 13 years ago by afb@…
I think it was mostly ready to go, but not submitted... Maybe it should be, if someone wanted to look at 4.10 ?
comment:15 Changed 11 years ago by cooljeanius (Eric Gallager)
r107757 noted that a bunch of the xfce ports were broken...
comment:16 Changed 11 years ago by afb@…
Seems like r107757 noted that intltool is broken ? But yeah, it also noted that xfce ports are outdated.
comment:17 follow-up: 19 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)
This patch no longer applies, but a quick comment anyways...
patch-environ.diff is wrong. You should just #include <crt_externs.h> rather than declaring that yourself.
Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)
Attachment: | xfcelibs.patch added |
---|
updates core xfce libs to 4.10 versions
comment:18 follow-up: 20 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)
I spent a few minutes on this updating the core libraries (patch attached). Someone else needs to pick up the torch and complete the work if they care about having xfce in MacPorts.
comment:19 Changed 11 years ago by afb@…
Replying to jeremyhu@…:
This patch no longer applies, but a quick comment anyways...
patch-environ.diff is wrong. You should just #include <crt_externs.h> rather than declaring that yourself.
Sounds right. Not sure that it actually matters, those definitions/that file isn't updated much.
comment:20 Changed 11 years ago by afb@…
Replying to jeremyhu@…:
I spent a few minutes on this updating the core libraries (patch attached). Someone else needs to pick up the torch and complete the work if they care about having xfce in MacPorts.
I don't really care about fixing Xfce, but I think I have enough patches for it. Or maybe it's more that I don't care if it works from MacPorts ports, but anyway...
If anyone else want to maintain, feel free to apply (again). Meanwhile, I'll fix it.
comment:21 Changed 10 years ago by afb@…
Seems like people keep filing and updating bugs on Xfce, guess it should be updated and tested on Mavericks...
It can probably "borrow" some stuff from http://svnweb.freebsd.org/ports/head/x11-wm/xfce4/ and its friends ?
comment:22 Changed 9 years ago by afb@…
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed, r144133.
Skipped the existing 4.8, took a jump over 4.10 and went straight for 4.12. Removed Terminal and Midori from the standard install, to simplify things...
Cobined diff for updated ports