Opened 13 years ago

Closed 13 years ago

#31286 closed enhancement (fixed)

p5-perlmagick: simplify setting archflags

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: astricker@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: p5-perlmagick

Description

This patch simplifies how p5-perlmagick sets its archflags. May I commit it?

Attachments (1)

p5-perlmagick.diff​ (643 bytes) - added by ryandesign (Ryan Carsten Schmidt) 13 years ago.
proposed patch

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: p5-perlmagick.diff​ added

proposed patch

comment:1 Changed 13 years ago by astricker@…

Looking at the source for get_canonical_archflags in portutil.tcl:

  • If the flag is universal it returns the universal_cflags
  • IF the flag is not universal it returns the configured tool archflags, in case of cc this are the cc_archflags

So this is basically the same result.

For me this looks like a sane change.

comment:2 in reply to:  1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: new → closed

Replying to astricker@…:

So this is basically the same result.

That's right. It's a new shortcut introduced in MacPorts 2.

For me this looks like a sane change.

Committed in r84111.

Note: See TracTickets for help on using tickets.