live555 copies entire worksrcdir into destroot

[ryandesign (Ryan Carsten Schmidt)]

The live555 port copies the entire worksrcdir into the destroot. The authors of the software ​suggest this as a viable installation procedure, but it hardly seems desirable, since all sorts of irrelevant files (source code, object files, etc.) get installed as well. This was brought up in #31318 but deserves its own ticket.

[ak.ml@…]

Associated tardiff

[ak.ml@…]

Since I'm not familiar with TCL I've issued shells commands. Basically I'm creating a list of files before/after build so that I can determine the new files. From the original files I keep the include files, from the new files I remove the object files and Makefiles.
I haven't modified the structure of the binary distribution since this would also imply reviewing dependents of live555 i.e. VLC and MPlayer.

As for the tardiff, if you filter out *.cpp and *.o files:

$ cat live555-tardiff.txt | egrep -v -e '\.o$' -e '\.cpp$'
- opt/local/lib/live/BasicUsageEnvironment/COPYING
- opt/local/lib/live/BasicUsageEnvironment/Makefile
- opt/local/lib/live/BasicUsageEnvironment/Makefile.head
- opt/local/lib/live/BasicUsageEnvironment/Makefile.tail
- opt/local/lib/live/COPYING
- opt/local/lib/live/Makefile
- opt/local/lib/live/Makefile.head
- opt/local/lib/live/Makefile.tail
- opt/local/lib/live/README
- opt/local/lib/live/UsageEnvironment/COPYING
- opt/local/lib/live/UsageEnvironment/Makefile
- opt/local/lib/live/UsageEnvironment/Makefile.head
- opt/local/lib/live/UsageEnvironment/Makefile.tail
- opt/local/lib/live/WindowsAudioInputDevice/WindowsAudioInputDevice.mak
- opt/local/lib/live/config.aix
- opt/local/lib/live/config.alpha
- opt/local/lib/live/config.armeb-uclibc
- opt/local/lib/live/config.armlinux
- opt/local/lib/live/config.avr32-linux
- opt/local/lib/live/config.bfin-linux-uclibc
- opt/local/lib/live/config.bfin-uclinux
- opt/local/lib/live/config.bsplinux
- opt/local/lib/live/config.cris-axis-linux-gnu
- opt/local/lib/live/config.cygwin
- opt/local/lib/live/config.cygwin-for-vlc
- opt/local/lib/live/config.freebsd
- opt/local/lib/live/config.iphoneos
- opt/local/lib/live/config.irix
- opt/local/lib/live/config.linux
- opt/local/lib/live/config.linux-64bit
- opt/local/lib/live/config.linux-gdb
- opt/local/lib/live/config.macosx
- opt/local/lib/live/config.macosx-before-version-10.4
- opt/local/lib/live/config.mingw
- opt/local/lib/live/config.openbsd
- opt/local/lib/live/config.qnx4
- opt/local/lib/live/config.solaris-32bit
- opt/local/lib/live/config.solaris-64bit
- opt/local/lib/live/config.sunos
- opt/local/lib/live/config.uClinux
- opt/local/lib/live/configure
- opt/local/lib/live/fix-makefile
- opt/local/lib/live/genMakefiles
- opt/local/lib/live/genWindowsMakefiles
- opt/local/lib/live/genWindowsMakefiles.cmd
- opt/local/lib/live/groupsock/COPYING
- opt/local/lib/live/groupsock/Makefile
- opt/local/lib/live/groupsock/Makefile.head
- opt/local/lib/live/groupsock/Makefile.tail
- opt/local/lib/live/groupsock/inet.c
- opt/local/lib/live/liveMedia/COPYING
- opt/local/lib/live/liveMedia/Makefile
- opt/local/lib/live/liveMedia/Makefile.head
- opt/local/lib/live/liveMedia/Makefile.tail
- opt/local/lib/live/liveMedia/RTSPServer.cpp.save
- opt/local/lib/live/liveMedia/include/#MediaSink.hh#
- opt/local/lib/live/liveMedia/include/RTSPServer.hh.save
- opt/local/lib/live/liveMedia/our_md5.c
- opt/local/lib/live/liveMedia/our_md5hl.c
- opt/local/lib/live/liveMedia/rtcp_from_spec.c
- opt/local/lib/live/mediaServer/COPYING
- opt/local/lib/live/mediaServer/DynamicRTSPServer.hh.new
- opt/local/lib/live/mediaServer/Makefile
- opt/local/lib/live/mediaServer/Makefile.head
- opt/local/lib/live/mediaServer/Makefile.tail
- opt/local/lib/live/testProgs/COPYING
- opt/local/lib/live/testProgs/Makefile
- opt/local/lib/live/testProgs/Makefile.head
- opt/local/lib/live/testProgs/Makefile.tail
- opt/local/lib/live/testProgs/testMP3-using-ADUs.sdp
- opt/local/lib/live/testProgs/testMP3.sdp
- opt/local/lib/live/testProgs/testMPEG1or2AudioVideo.sdp
- opt/local/lib/live/testProgs/testMPEG1or2Video.sdp
- opt/local/lib/live/testProgs/testMPEG2Transport.sdp
- opt/local/lib/live/win32config
- opt/local/lib/live/win32config.Borland

[ryandesign (Ryan Carsten Schmidt)]

Thanks, that looks pretty good. I committed a modified version in r84348. I made these changes:

• I generated the "before" list in post-configure instead of post-patch. That way, the Makefiles the configure process generates aren't considered new files and we don't have to delete them separately later.
• Instead of deleting items from the build directory in post-build, I deleted them in the destroot. This is more like how other ports' destroot phases work, and it will be more familiar to other port builders who might expect to see an intact build directory.
• I changed the ui_msgs to ui_debugs so they don't show up in the normal output.
• I used find's -s argument instead of piping to a separate sort process.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ak.ml@…:

Since I'm not familiar with TCL I've issued shells commands.

There are some Tcl commands that might help, like fs-traverse, but sometimes it's hard to beat a string of shell commands for getting a job done fast.