libffi: headers are merged improperly by muniversal portgroup

[herzog@…]

Installation of libffi via 'sudo port -svk install libffi +universal' creates a header file '/opt/local/lib/libffi-3.0.10/include/ffi.h' whose number of #if statements does not match the number of #endif's. For example, 'sudo port -svk install py27-gobject +universal' results in the following error code:

In file included from ffi-marshaller.c:24:
/opt/local/lib/libffi-3.0.10/include/ffi.h:53:1: error: unterminated #ifndef

This looks very similar to Ticket #25439 concerning an older version of this library.

[ryandesign (Ryan Carsten Schmidt)]

It builds fine for me for i386 x86_64 on Snow Leopard. Please let us know your OS version, your Xcode version, and your universal_archs, and please attach the problematic ffi.h. Thanks.

[herzog@…]

Here are the data you asked for and further items that may be helpfull:

Mac OS version:         Mac OS X 10.5.8
Xcode version:          Xcode 3.1.4
UNIVERSAL_ARCHS='i386 ppc' (as defined in ~/MacPorts/MacPortBuild/MacPorts-2.0.3/config.log )

The attached zip archive contains the installation logs from a completely fresh MacPorts system to the state when the problem occured.

[herzog@…]

The description of the problem is not quite correct: The header files for the ppc and i386 plattforms of libffi are completely okay.

The problem is the mechanism which glues together the headers for the different plattforms into a single universal header file.

For example, everything works well, if the files

• /opt/local/lib/libffi-3.0.10/include/ffi.h
• /opt/local/lib/libffi-3.0.10/include/ffitarget.h

are replaced by headers which include the appropriate headers from

• ...libffi/work/destroot-ppc and
• ...libffi/work/destroot-i386

respectively. Too see this, replace the directory

• /opt/local/lib/libffi-3.0.10/include

with the directory contained in the attachment 'include.zip'.

Replying to herzog@…:

Installation of libffi via 'sudo port -svk install libffi +universal' creates a header file '/opt/local/lib/libffi-3.0.10/include/ffi.h' whose number of #if statements does not match the number of #endif's. For example, 'sudo port -svk install py27-gobject +universal' results in the following error code:

In file included from ffi-marshaller.c:24:
/opt/local/lib/libffi-3.0.10/include/ffi.h:53:1: error: unterminated #ifndef

This looks very similar to Ticket #25439 concerning an older version of this library.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #32257.

[k.polezhaiev@…]

Cc Me!

[k.polezhaiev@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Now that I've had a chance to try this out on a Tiger machine, it looks like this is a reprise of an issue that was avoided when the universal variant was first introduced in r46771. The port says not to use the merger for ffitarget.h, but the headers have changed their location since then and the port wasn't updated accordingly, and now ffi.h is affected as well. Fixed in r87572.