Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#31508 closed defect (fixed)

emacs-app @23.3_2: fails to build with Xcode 4.2/Lion

Reported by: takanori@… Owned by: cssdev
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: emacs-app

Description

Due to some minor coding issues, emacs-app fails to build with Xcode 4.2 GM/Lion.

Attachments (3)

buildlog_emacs-app.txt​ (1.1 MB) - added by takanori@… 13 years ago.
emacs-app.diff​ (1.8 KB) - added by takanori@… 13 years ago.
Here is a patch to fix this problem.
patch-clang.diff​ (1002 bytes) - added by takanori@… 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by takanori@…

Attachment: buildlog_emacs-app.txt​ added

Changed 13 years ago by takanori@…

Attachment: emacs-app.diff​ added

Here is a patch to fix this problem.

comment:1 Changed 13 years ago by cssdev

Status: new → assigned

can you attach patch-clang.diff?

Changed 13 years ago by takanori@…

Attachment: patch-clang.diff​ added

comment:2 Changed 13 years ago by takanori@… 

can you attach patch-clang.diff?

I attached patch-clang.diff, though it was already included in emacs-app.diff. ;-)

comment:3 Changed 13 years ago by cssdev

Resolution: → fixed
Status: assigned → closed

Oops, I missed that. Looks clean to me, although I don't have XCode 4.2 to test. Committed in r85139. Thanks!

comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Supersedes #30850.

Note: See TracTickets for help on using tickets.