New Port(?): gtk-mac-integration

[royliu@…]

On my way to fixing another bug, I've had to introduce a new(?) port, gtk-mac-integration. The reason why I'm hesitant to call it a new port is because it seems like an upgrade of the gtk-osx-application port. As such, I've shamelessly ripped off portions of that port, cc'ed its maintainer, and uploaded the new(?) Portfiles.

[royliu@…]

The Portfile.

[royliu@…]

Patch #1.

[royliu@…]

Patch #2.

[royliu@…]

Patch #3.

[royliu@…]

Patch #4.

[ryandesign (Ryan Carsten Schmidt)]

Do these two ports install the same files? If so does gtk-mac-integration replace ige-osx-integration? Or do they serve different purposes, install different files, and coexist peacefully?

[ryandesign (Ryan Carsten Schmidt)]

Sorry... gtk-osx-application, not ige-osx-integration (which doesn't exist). But ige-mac-integration does exist. Is that the same as this new port? Or different?

[royliu@…]

Actually, they're the same package, just renamed and version incremented. See this changelog for the rename event:

​http://ftp.gnome.org/pub/GNOME/sources/gtk-mac-integration/1.0/gtk-mac-integration-1.0.0.changes

What should be done? Currently MacPorts has ige-mac-integration and gtk-osx-application. I got confused when I first stumbled upon these. Shall we consolidate everything?

[elelay (Eric Le Lay)]

ige-mac-integration is still a dependency of trunk/dports/audio/gmpc, trunk/dports/audio/glade3, trunk/dports/audio/gtksourceview2. Last time I couldn't investigate if they were compatible with gtk-osx-application so it has to stay this way, I'd say.

gtk-osx-application is only required by trunk/dports/gnome/gpodder, which I also maintain so I could test any change.

About creating a new port gtk-mac-integration, I'm not convinced. As stated in ​http://live.gnome.org/GTK%2B/OSX/Integration#Gtk-mac-integration.2BAC8-GtkOSXApplication, ige-mac-integration is the deprecated module, which has been renamed to gtk-mac-integration, but GtkOSXApplication stays. OK, the distfile is now gtk-mac-integration.tar.bz2, but it was ige-mac-integration.tar.bz2 so no much change.

[royliu@…]

elelay,

If gtk-mac-integration is deprecated, then gtk-osx-application is too! This line in the gtk-osx-application Portfile shows that it uses the same codebase:

distname        ige-mac-integration-${version}

Also, notice that:

• The version 1.01 is oddly a small version bump from 0.96. See the changelog.
• The bug fixed by this ​patch is superceded by gtk-mac-integration.

I appreciate your input into this matter. I'm just a GTK newbie trying to make changes that'll eventually culminate in a patch to an otherwise broken inkscape +quartz. Still, I think it would be nice if we could consolidate gtk-osx-application and gtk-mac-integration. I suspect that if you plugged in gtk-mac-integration as a dependency to your gpodder dependent, it would work.

[elelay (Eric Le Lay)]

Replying to royliu@…:

elelay,

If gtk-mac-integration is deprecated, then gtk-osx-application is too!

In fact, gtk-mac-integration.tar.bz2 contains 2 "modules", one is the old (using Carbon) ige-mac-integration renamed to gtk-mac-integration (because ige had some meaning related to the company writing it in the first place, if I remember correctly), the other module is the (not so) new GTKOSXApplication. The old library is deprecated in favor of the new one. Is that more clear ?

Also, notice that:

• The version 1.01 is oddly a small version bump from 0.96. See the changelog.
• The bug fixed by this ​patch is superceded by gtk-mac-integration.

This is why I marked it as temporary fix for version 0.9.6 in the Portfile.

I appreciate your input into this matter. I'm just a GTK newbie trying to make changes that'll eventually culminate in a patch to an otherwise broken inkscape +quartz. Still, I think it would be nice if we could consolidate gtk-osx-application and gtk-mac-integration. I suspect that if you plugged in gtk-mac-integration as a dependency to your gpodder dependent, it would work.

Sure, it would work but why introduce a new port for exactly the same package (repeating #25025, without the rationale of an updated API, or is there : in the mean time, ige-mac-integration has been updated to 0.9.8 - see #29656 and they mention a switch to PyGI ; is it a gtk3 thing or still compatible with gtk2 ?). I'd rather see gtk-osx-application's version upgraded to 1.0.1.

And I would appreciate seeing a not broken inkscape +quartz by the way :-)

[royliu@…]

elelay,

Pardon my confusion. I was under the impression that gtk-mac-integration was the new name representing both implementations. If that's not the case, then upgrading gtk-osx-application would be the way to go. If that's the case, then I've already done the patching work for you.

[elelay (Eric Le Lay)]

royliu, yes, you did all the hard work indeed ! I just tested gPodder with version 1.0.1 and discovered that it uses the deprecated igemacintegration python module, so requires a bit of renaming (but works in the end). I'll issue a patch soon.

And contrary to what I feared 1.0.1 still works with gtk2. So I don't see any reason to keep gtk-osx-application as is (with an old 0.9 version I mean). And since ige-mac-integration has been updated to 0.9.8, maybe the applications depending on it could work with 1.0.1 so could switch to gtk-osx-application. adding snc to the cc list, since he committed the last change to ige-mac-integration.

[elelay (Eric Le Lay)]

updated gtk-osx-application to 1.0.1 in r86633 Thanks for your work, royliu !!

[royliu@…]

Would it be possible to bump the default Python version to 2.7? That seemed to have already happened in Inkscape.

[elelay (Eric Le Lay)]

Replying to royliu@…: sure, done :-)