Opened 13 years ago

Closed 13 years ago

#31851 closed defect (fixed)

subtitleripper @0.3-4_1 fails to build under 10.7

Reported by: r.pedroche.novillo@… Owned by: stephen@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: lion haspatch Cc: ryandesign (Ryan Carsten Schmidt)
Port: subtitleripper

Description

subtitleripper port fails to build in Lion, resulting in the following errors in main.log:

:info:build Compiling vobsub2pgm.c
:info:build vobsub.c:60: error: static declaration of ‘getline’ follows non-static declaration
:info:build /usr/include/stdio.h:449: error: previous declaration of ‘getline’ was here
:info:build vobsub.c: In function ‘vobsub_open’:
:info:build vobsub.c:912: warning: cast to pointer from integer of different size
:info:build make: *** [vobsub.o] Error 1

The package assumes there is no "getline" function in standard library, but it seems to have been added in 10.7 (my Snow Leopard box lacks it).

The bug is in the original package itself, which seems unmantained, but it is easily worked around with a trivial change to the port file (complete Portfile attached):

--- Portfile.old	2011-02-23 07:00:16.000000000 +0100
+++ Portfile	2011-11-01 20:32:24.000000000 +0100
@@ -34,6 +34,12 @@
                     CFLAGS="${configure.cflags}" \
                     LDFLAGS="${configure.ldflags}"
 
+platform darwin 11 {
+    build.args      CC="${configure.cc} ${configure.cc_archflags}" \
+                    CFLAGS="${configure.cflags} -DHAVE_GETLINE" \
+                    LDFLAGS="${configure.ldflags}"
+}
+
 destroot {
     xinstall -W ${worksrcpath} \
         srttool \

Attachments (2)

Portfile (1.6 KB) - added by r.pedroche.novillo@… 13 years ago.
Fixed Portfile
subtitleripper.diff (468 bytes) - added by ryandesign (Ryan Carsten Schmidt) 13 years ago.
proposed patch

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by r.pedroche.novillo@…

Attachment: Portfile added

Fixed Portfile

Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: subtitleripper.diff added

proposed patch

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added; stephen@… removed
Keywords: lion haspatch added; getline removed
Owner: changed from macports-tickets@… to stephen@…
Summary: subtitle ripper @0.3-4_1 fails to build under 10.7subtitleripper @0.3-4_1 fails to build under 10.7

Instead of overwriting build.args it would be better to just append to configure.cflags. Attached is a patch that does this. Stephen, may I commit it?

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

r87178 (maintainer timeout)

Note: See TracTickets for help on using tickets.