gdb @7.3 fails to build with clang

[gthb (Gunnlaugur Thor Briem)]

Salient bit from main.log:

:info:build bfdio.c:580:3: error: argument to 'sizeof' in '__builtin___memset_chk' call is the same expression as the destination; did you mean to dereference it? [-Werror,-Wsizeof-pointer-memaccess]
:info:build   memset (statbuf, 0, sizeof (statbuf));
:info:build   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build /usr/include/secure/_string.h:77:41: note: instantiated from:
:info:build    ? __builtin___memset_chk (dest, val, len, __darwin_obsz0 (dest))     \
:info:build                                         ^
:info:build bfdio.c:580:31: note: instantiated from:
:info:build   memset (statbuf, 0, sizeof (statbuf));
:info:build           ~~~~~~~             ^~~~~~~

The compiler has a point there, and upstream has patched this 6 months ago:

​http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfdio.c.diff?r1=1.27&r2=1.28&cvsroot=src

[gthb (Gunnlaugur Thor Briem)]

Patching to use *statbuf does get past this, but hits another issue. Seems like gdb is not ready for clang; patching portfile to build with llvm-gcc-4.2 gets gdb to build; will attach.

[gthb (Gunnlaugur Thor Briem)]

Use llvm-gcc-4.2 instead of clang to get gdb to build on Lion

[ryandesign (Ryan Carsten Schmidt)]

If upstream has already fixed this 6 months ago, then we should update gdb to version 7.3.1 (released 2 months ago).

[gthb (Gunnlaugur Thor Briem)]

We probably should, yes, but it seems they didn't put this fix on the 7.3.x branch; I tried updating the portfile to 7.3.1 but it still hit this error (and more, when I patched it) so I didn't post the portfile patch.

[ryandesign (Ryan Carsten Schmidt)]

Replying to gunnlaugur@…:

patching portfile to build with llvm-gcc-4.2 gets gdb to build; will attach.

Thanks. r88366.

[jeremyhu (Jeremy Huddleston Sequoia)]

This is an obvious bug in the project (even when built with gcc).

[jeremyhu (Jeremy Huddleston Sequoia)]

r91326