Opened 13 years ago
Closed 8 years ago
#32316 closed enhancement (fixed)
vorbisgain @0.34 Add recursive variant
| Reported by: | macports.org@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.3 |
| Keywords: | haspatch | Cc: | khindenburg@… |
| Port: | vorbisgain |
Description
I prefer to use vorbisgain's --recursive option over invoking vorbisgain with sets of files making up an album.
I've attached the (very simple) variant to enable the option as a patch.
Attachments (1)
Change History (7)
Changed 13 years ago by macports.org@…
| Attachment: | vorbisgain_recursive_variant.diff added |
|---|
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|---|
| Owner: | changed from macports-tickets@… to ryandesign@… |
comment:2 Changed 13 years ago by macports.org@…
The --recursive option was moved to a configuration switch because people complained that on UNIX the proper way would be to use find and friends, which I personally find to be cumbersome to group files as albums.
Not making this a variant but a default would be preferable!
comment:3 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)
| Cc: | khindenburg@… added |
|---|
Any objection to just adding the configure line by default and updating to recent version?
comment:6 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Does adding this option change existing behavior of vorbisgain, or only make additional features available? Or, is there any reason why anyone would want this option to be disabled? I suspect we should not make it a variant; we should just enable it always (unless you can think of a reason why we wouldn't want to do that).