Opened 13 years ago

Closed 8 years ago

#32316 closed enhancement (fixed)

vorbisgain @0.34 Add recursive variant

Reported by: macports.org@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: khindenburg@…
Port: vorbisgain

Description

I prefer to use vorbisgain's --recursive option over invoking vorbisgain with sets of files making up an album.

I've attached the (very simple) variant to enable the option as a patch.

Attachments (1)

vorbisgain_recursive_variant.diff (428 bytes) - added by macports.org@… 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by macports.org@…

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to ryandesign@…

Does adding this option change existing behavior of vorbisgain, or only make additional features available? Or, is there any reason why anyone would want this option to be disabled? I suspect we should not make it a variant; we should just enable it always (unless you can think of a reason why we wouldn't want to do that).

comment:2 Changed 13 years ago by macports.org@…

It does not, as far as I can discern, change existing behaviour. It only adds the -rrecursive command line switch (a new feature).

The --recursive option was moved to a configuration switch because people complained that on UNIX the proper way would be to use find and friends, which I personally find to be cumbersome to group files as albums.

Not making this a variant but a default would be preferable!

comment:3 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Any objection to just adding the configure line by default and updating to recent version?

comment:4 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

No objection.

comment:5 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

In e696726b/macports-ports:

vorbisgain: update to 0.37

Add --enable-recursive per #32316

comment:6 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.