Opened 13 years ago
Closed 13 years ago
#32332 closed defect (fixed)
vim, vim-app, MacVim: remove nls variant
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.3 |
| Keywords: | haspatch | Cc: | florian@… |
| Port: | vim, vim-app, MacVim |
Description
In r24862 vim's gettext support was moved to a variant. MacVim inherited this when it was created in r47370. An nls variant was also snuck into the vim-app port in r32061, though that revision was described as only adding variant descriptions; indeed, vim-app does not disable nls by default. So most vim-app users probably already have nls support, though the port does not declare a dependency on gettext.
I see no reason for natural language support to be optional. This was previously mentioned in comment:ticket:32304:4. See attached patches.
Attachments (3)
Change History (4)
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | vim-app.diff added |
|---|
proposed patch for vim-app
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | MacVim.diff added |
|---|
proposed patch for MacVim
comment:1 Changed 13 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I agree that +nls isn't really necessary and most users will already have gettext as a dependency for other ports anyway.
Thank you for your patches, committed in r87675.
proposed patch for vim