#32438 closed enhancement (fixed)
haproxy: archs, universal, compiler, pcre, crypt, regparm, livecheck, license
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | sam@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.0.3 |
Keywords: | haspatch | Cc: | pmq@… |
Port: | haproxy |
Description
The attached patch makes numerous improvements to the haproxy port:
- Make the universal variant work right and respect build_arch
- Ensure we're UsingTheRightCompiler
- Add dependency on and enable use of PCRE, which the Makefile says is recommended
- Enable the use of libcrypt, which the Makefile says is recommended (had to patch the Makefile, because on OS X one does not use
-lcrypt
) - Enable regparm optimization on Intel processors, which the Makefile says it is recommended
- Fix the livecheck
- Indicate license
- Simplify how the documentation and other files are installed into the right place (set PREFIX and DOCDIR as destroot.args)
- Introduce the branch variable in master_sites so it won't have to be updated at the next major version
The whitespace of my changes conforms to our recommended whitespace rules, not the portfile's existing conventions. As a second commit, I would like to change the whitespace of the remaining lines to conform to our recommended style, and then add our standard modeline to indicate that this is the case.
May I commit these changes?
Attachments (1)
Change History (3)
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | haproxy.diff added |
---|
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | new → closed |
r87959 (maintainer timeout)
comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to ryandesign@…:
As a second commit, I would like to change the whitespace of the remaining lines to conform to our recommended style, and then add our standard modeline to indicate that this is the case.
Note: See
TracTickets for help on using
tickets.
proposed patch