Opened 13 years ago

Closed 11 years ago

#32533 closed enhancement (fixed)

txt2regex: noarch; license; manpage location

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: grrr@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: txt2regex

Description

The txt2regex port installs a manpage, but with the wrong extension (".man" instead of the required ".1"), so "man txt2regex" doesn't actually find it. The attached Portfile patch fixes this, and indicates that the port doesn't install any architecture-specific files, and builds and installs the localized message catalogs.

It does this by removing the custom destroot phase the Portfile had been using, and instead patching the Makefile to work properly. The Makefile patch makes the following changes:

  • Introduces PREFIX variable and uses it instead of assuming /usr
  • Fixes how DESTDIR is handled so that DESTDIR doesn't get written into the final txt2regex script
  • Replaces "echo -n" (which doesn't work as intended on POSIX-compliant systems like Snow Leopard and higher) with "printf"
  • Installs manpage

The Makefile patch should be suitable for submission to the developers of this software, if they're interested.

Attachments (3)

patch-Makefile.diff (2.4 KB) - added by ryandesign (Ryan Carsten Schmidt) 13 years ago.
Makefile patch
Portfile.diff (1016 bytes) - added by ryandesign (Ryan Carsten Schmidt) 13 years ago.
Portfile patch
patch-txt2regex-Portfile.diff (1.1 KB) - added by jul_bsd@… 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: patch-Makefile.diff added

Makefile patch

Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: Portfile.diff added

Portfile patch

comment:1 Changed 11 years ago by jul_bsd@…

Gave a try on Mavericks and fails at build

compiling pt_BR.po...ok
compiling ro_RO.po...ok
sed -e '/^TEXTDOMAINDIR=/s,=.*,=/opt/local/share/locale,' \
            -e '/^VERSION=/s/=.*/=0.8/' txt2regex-0.8.sh > /Volumes/Data/opt/local/var/macports/build/_Volumes_Data_myports_sysutils_txt2regex/txt2regex/work/destroot/opt/local/bin/txt2regex && \
        chmod +x /Volumes/Data/opt/local/var/macports/build/_Volumes_Data_myports_sysutils_txt2regex/txt2regex/work/destroot/opt/local/bin/txt2regex && \
        echo "program 'txt2regex' installed. just run /Volumes/Data/opt/local/var/macports/build/_Volumes_Data_myports_sysutils_txt2regex/txt2regex/work/destroot/opt/local/bin/txt2regex"
sed: RE error: illegal byte sequence
make: *** [install] Error 1
make: Leaving directory `/Volumes/Data/opt/local/var/macports/build/_Volumes_Data_myports_sysutils_txt2regex/txt2regex/work/txt2regex-0.8'

just send LANG & co as destroot.env and after it's ok

Changed 11 years ago by jul_bsd@…

comment:2 Changed 11 years ago by grrr@…

It's definitely a locale related issue, it builds and installs fine for me (10.9.2, US).

comment:3 in reply to:  1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to jul_bsd@…:

Gave a try on Mavericks and fails at build

This is a separate issue and should be a separate ticket; the maintainer filed it as #43268.

comment:4 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.