#32589 closed defect (fixed)
portlivecheck.tcl: fix regex multiple versions on single line
| Reported by: | pixilla (Bradley Giesbrecht) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | base | Version: | 2.0.3 |
| Keywords: | haspatch maintainer | Cc: | raimue (Rainer Müller), ryandesign (Ryan Carsten Schmidt), jmroot (Joshua Root) |
| Port: |
Description (last modified by pixilla (Bradley Giesbrecht))
See r88031 and list archive
Attachments (1)
Change History (6)
Changed 13 years ago by pixilla (Bradley Giesbrecht)
| Attachment: | patch-base-src-port1.0-portlivecheck.tcl.diff added |
|---|
comment:1 Changed 13 years ago by pixilla (Bradley Giesbrecht)
| Description: | modified (diff) |
|---|
comment:2 Changed 13 years ago by pixilla (Bradley Giesbrecht)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 13 years ago by jmroot (Joshua Root)
The livecheck for sdlconsole still doesn't work correctly after this change, JFYI.
comment:4 Changed 13 years ago by raimue (Rainer Müller)
livecheck.regex ${name}-(\[0-9.\]+)
I would say this sdlconsole regex is wrong, as this also matches the dot of .tar.gz in the string sdlconsole-2.1.tar.gz and thus, the result of the match is 2.1.
There are multiple options to fix the regex which are compatible to previous releases of MacPorts:
livecheck.regex ${name}-(\[0-9.\]+)\.tar
livecheck.regex ${name}-(\\d+(?:\\.\\d+)+)
comment:5 Changed 13 years ago by pixilla (Bradley Giesbrecht)
livecheck.regex "${name}-((?!.*${name}.*|\\${extract.suffix}).*)\\${extract.suffix}"
Note: See
TracTickets for help on using
tickets.
Commit r88177