Opened 13 years ago

Closed 13 years ago

#32970 closed defect (fixed)

iodine should be UsingTheRightCompiler

Reported by: nerdling (Jeremy Lavergne) Owned by: tomhennigan@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: iodine

Description

cc -c -g -Wall -DDARWIN -pedantic tun.c -o tun.o
cc: Error: You should be using ${configure.cc}
See http://trac.macports.org/wiki/UsingTheRightCompiler
make[1]: *** [tun.o] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_iodine/iodine/work/iodine-0.6.0-rc1/src'

Attachments (2)

Portfile (1.0 KB) - added by tomhennigan@… 13 years ago.
Updated version of iodine Portfile
Portfile.diff (1.3 KB) - added by nerdling (Jeremy Lavergne) 13 years ago.
non-whitespace diff from: svn diff -x -w Portfile

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by tomhennigan@…

Attachment: Portfile added

Updated version of iodine Portfile

comment:1 Changed 13 years ago by tomhennigan@…

I've updated the Portfile and attached it above. jann@… previously committed the portfile and patch I sent up so this ticket should now be attached to them or someone else from the ports team to review.

comment:2 Changed 13 years ago by raimue (Rainer Müller)

Port updates are preferred to be submitted as unified diffs. In this case, you did not only fix the bug in question, but also changed large parts of whitespace in the Portfile. This makes it hard to see what was actually changed. Please submit a separate diff for the changes involving whitespace only.

Changed 13 years ago by nerdling (Jeremy Lavergne)

Attachment: Portfile.diff added

non-whitespace diff from: svn diff -x -w Portfile

comment:3 Changed 13 years ago by nerdling (Jeremy Lavergne)

I'll start testing your patch, also supplied a non-whitespace diff for easier viewing.

comment:4 Changed 13 years ago by nerdling (Jeremy Lavergne)

Resolution: fixed
Status: newclosed

Also added missing platforms: r89234.

Note: See TracTickets for help on using tickets.