#33120 closed submission (fixed)
new Portfile for libbert
Reported by: | mail@… | Owned by: | drkp (Dan Ports) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt) | |
Port: | libbert |
Description
Attachments (3)
Change History (11)
Changed 13 years ago by mail@…
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 follow-up: 7 Changed 13 years ago by mail@…
- done
- doesn't work, because the port group cmake does an in source build
CMake Error at CMakeLists.txt:44 (message): In-source builds are not permitted. Make a separate folder for building: mkdir build; cd build; cmake .. Before that, remove the files that cmake just created: rm -rf CMakeCache.txt CMakeFiles
Changed 13 years ago by mail@…
Attachment: | Portfile.2 added |
---|
comment:3 Changed 13 years ago by mf2k (Frank Schima)
Version: | 2.0.3 |
---|
The revision line needs to be deleted.
Changed 13 years ago by mail@…
Attachment: | Portfile.3 added |
---|
comment:5 Changed 13 years ago by drkp (Dan Ports)
Owner: | changed from macports-tickets@… to dports@… |
---|---|
Status: | new → assigned |
comment:6 Changed 13 years ago by drkp (Dan Ports)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Thanks, I committed the port in r89890.
Let's call the license just zlib
because the beer clause doesn't actually affect the license and I didn't feel like adding to the approved licenses list.
comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|
Replying to mail@…:
- doesn't work, because the port group cmake does an in source build
Ah, so it uses cmake, but has a wrapper configure script that does an out-of-source build. Well, ok. Note that many of the ports that use the cmake portgroup add code to do an out-of-source build. It might make sense to modify the cmake portgroup to let it do out-of-source builds. I've filed #33259 for that.
comment:8 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
Note: See
TracTickets for help on using
tickets.
You don't need to specify the homepage because the github portgroup does that for you.
Instead of manually specifying a build dependency on cmake and changing configure.pre_args, why not use the cmake portgroup?