Opened 13 years ago

Closed 12 years ago

#33503 closed enhancement (fixed)

ffmpeg-devel: explicitly disable opencore-amr

Reported by: janstary (Jan Starý) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: jeremyhu (Jeremy Huddleston Sequoia)
Port: ffmpeg-devel

Description

Attached is a patch to Portfile which explicitly disables the use on recently introduced audio/opencore-amr, so that we are sure there are no hiden dependencies.

Attachments (1)

Portfile-ffmpeg-devel.diff (386 bytes) - added by janstary (Jan Starý) 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by janstary (Jan Starý)

Attachment: Portfile-ffmpeg-devel.diff added

comment:1 Changed 13 years ago by janstary (Jan Starý)

Any comments?

comment:2 Changed 12 years ago by jmroot (Joshua Root)

Cc: jeremyhu@… added
Owner: changed from macports-tickets@… to devans@…
Version: 2.0.4

comment:3 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed

r96093

I'm concerned that you said it was just picking up the library when present. The configure script requires --enable-version3 to manually enable opencore-amr support, meaning it is GPL-3+. Hopefully that is now moot with r96093, but I am concerned that some built code might be tagged LGPL-2.1+ even though it is GPL-3+. That is on ffmpeg to deal with though, since we were running configure properly by their instructions.

Note: See TracTickets for help on using tickets.