Opened 13 years ago

Closed 11 years ago

#33634 closed enhancement (duplicate)

seqan: various improvements

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: david.weese@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: knut.reinert@…
Port: seqan

Description

Here's patch to make various improvements that I was going to suggest when the port was submitted in #31429.

CMake portgroup

This port configures using cmake, therefore this patch makes the port use the cmake portgroup, which allows us to remove various other lines from the portfile.

Dependencies

The software links with libz.dylib, so this patch adds a library dependency on port:zlib. The port had a library dependency on port:cmake; this was incorrect since cmake was only used a configure time. Using the cmake portgroup correctly makes port:cmake a build dependency. So that the zlib dependency is properly recorded in the user's port registry, the revision is increased.

Universal variant

Currently, choosing the universal variant results in:

CMake Error: The source directory "/opt/local/var/macports/build/_Users_rschmidt_macports_dports-clean_science_seqan/seqan/work/seqan-1.3.1/cmake/--disable-dependency-tracking" does not exist.

Using the cmake portgroup handles the universal variant correctly and gets past this error, however then lands at the same i386 build error described in #33633. Therefore this patch disables the universal variant.

Attachments (1)

seqan.diff (1.4 KB) - added by ryandesign (Ryan Carsten Schmidt) 13 years ago.
proposed patch

Download all attachments as: .zip

Change History (2)

Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: seqan.diff added

proposed patch

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Resolution: duplicate
Status: newclosed
Version: 2.0.4

Handled in #43072.

Note: See TracTickets for help on using tickets.