Opened 13 years ago
Closed 12 years ago
#33849 closed update (duplicate)
py26-openbabel: update to 2.3.0
Reported by: | atenderholt@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.0.4 |
Keywords: | haspatch | Cc: | mlund (Mikael Lund), ryandesign (Ryan Carsten Schmidt) |
Port: | py26-openbabel |
Description
Update port to match version of newest OpenBabel (2.3.0) in MacPorts.
Based on the py27-openbabel Portfile (ticket #33848). Note that I have not tested this with Python 2.6, but the Python 2.7 version works fine.
Attachments (1)
Change History (4)
Changed 13 years ago by atenderholt@…
comment:1 follow-up: 2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | haspatch added |
---|---|
Summary: | update port: py26-openbabel → py26-openbabel: update to 2.3.0 |
In the future, for existing ports, please supply a unified diff of your changes instead of a complete new port; that makes it easier to review your proposed changes.
-I${prefix}/include/openbabel-2.0
does not belong in build.target. It might belong in build.args but I'm still uncomfortable about hardcoding that value, specifically the 2.0 version number which seems likely to change in future versions of openbabel. Is there a way to ask openbabel for this value -- maybe via a config script or pkg-config?
comment:2 Changed 13 years ago by atenderholt@…
Replying to ryandesign@…:
In the future, for existing ports, please supply a unified diff of your changes instead of a complete new port; that makes it easier to review your proposed changes.
Thanks for the tip, I completely forgot that a diff is more appropriate.
-I${prefix}/include/openbabel-2.0
does not belong in build.target. It might belong in build.args but I'm still uncomfortable about hardcoding that value, specifically the 2.0 version number which seems likely to change in future versions of openbabel. Is there a way to ask openbabel for this value -- maybe via a config script or pkg-config?
I'm not sure why, but pkg-config expects openbabel-2.0 to be passed to it instead of openbabel or openbabel-${version}. Nothing in the openbabel Portfile suggests why this is the case. What is the best way to proceed?
comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|---|
Resolution: | → duplicate |
Status: | new → closed |
A new unified py-openbabel port has been submitted in #33848 which supersedes this ticket.
Portfile for py26-openbabel