Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#33941 closed update (fixed)

zeroinstall-injector update

Reported by: dave@… Owned by: afb@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: drkp (Dan Ports)
Port: zeroinstall-injector

Attachments (1)

Portfile.patch (799 bytes) - added by dave@… 13 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: afb removed
Owner: changed from macports-tickets@… to afb@…

The Cc field must contain complete email addresses.

We prefer updates be submitted as unified diffs attached directly to the ticket.

comment:2 Changed 13 years ago by afb@…

Resolution: fixed
Status: newclosed

Updated, r91736.

Didn't change distfiles or checksum types.

comment:3 Changed 13 years ago by afb@…

Version: 2.0.4

Also added a test phase, and a small patch to make it pass:

Result <unittest._TextTestResult run=214 errors=0 failures=0>

comment:4 in reply to:  2 Changed 13 years ago by dave@…

Replying to afb@…:

Updated, r91736.

Didn't change distfiles or checksum types.

There's something I don't understand: how does it know what the archive is, without distfiles?

comment:5 Changed 13 years ago by afb@…

You only need to change "distfiles" if there is something wrong with the default value.

comment:6 Changed 13 years ago by drkp (Dan Ports)

Cc: dports@… added

Does this really require py26-xml? This is one of the few ports depending on py-xml, which is obsolete enough that we should try to remove it: see ticket:32090:comment:12

comment:7 Changed 13 years ago by drkp (Dan Ports)

or, in correct wikiformatting, comment:ticket:32090:12

comment:8 in reply to:  5 ; Changed 13 years ago by dave@…

Replying to afb@…:

You only need to change "distfiles" if there is something wrong with the default value.

Sheesh. That is so not an answer to the question I asked. Trying to learn something here. How does MacPorts know where to find the archive when there's no value set for distfiles in the Portfile?

comment:9 in reply to:  8 Changed 13 years ago by afb@…

Replying to dave@…:

Sheesh. That is so not an answer to the question I asked. Trying to learn something here. How does MacPorts know where to find the archive when there's no value set for distfiles in the Portfile?

The default value for distfiles includes the distname (which in turn is based on name and version) and the extract.suffix (which in turn is affected by use_bzip2).

See http://guide.macports.org/#reference.phases.fetch

comment:10 in reply to:  6 Changed 13 years ago by afb@…

Replying to dports@…:

Does this really require py26-xml? This is one of the few ports depending on py-xml, which is obsolete enough that we should try to remove it: see ticket:32090:comment:12

It probably doesn't, no.

comment:11 Changed 13 years ago by dave@…

Resolution: fixed
Status: closedreopened

Well, using Python 2.7 breaks feeds like 0publish. Attaching a fix.

Changed 13 years ago by dave@…

Attachment: Portfile.patch added

comment:12 Changed 13 years ago by afb@…

It doesn't say what the breakage is, but python27 could be made into a variant.

comment:13 Changed 13 years ago by afb@…

Resolution: fixed
Status: reopenedclosed

Added +python26 and +python27 variants in r91794.

comment:14 in reply to:  12 Changed 13 years ago by dave@…

Replying to afb@…:

It doesn't say what the breakage is, but python27 could be made into a variant.

I'm presuming you saw my report about the breakage in the 0install mailing list.

Note: See TracTickets for help on using tickets.