Opened 13 years ago
Closed 13 years ago
#34001 closed submission (fixed)
games/widelands
| Reported by: | pusteblumekuchen@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | widelands |
Description
add widelands to macports...
Attachments (5)
Change History (13)
Changed 13 years ago by pusteblumekuchen@…
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added |
|---|---|
| Port: | widelands added |
Some comments:
- You should not unconditionally set the compiler to llvm-gcc-4.2. See wiki:PortfileRecipes#compiler.
- You should not put a "/" before ${applications_dir} because ${applications_dir} already begins with a "/".
- It might be simpler to write the Info.plist as a normal text file in the files directory that can then simply be copied into the right place in post-destroot.
- Is "wdld" really the existing accepted creator code of Widelands or did you just make it up? The Apple Creator Code Registration document says "Your creator code […] cannot contain all lower case characters"; these have traditionally been reserved for use by Apple itself.
comment:2 Changed 13 years ago by pusteblumekuchen@…
- Thank you for your feedback. I immediately changed Point one and two.
- Since I have already written the tcl script, it will have the advantage of updating the version automatically.
- "wdld" is not an apple registered Creator Code, and is indeed made up. I didn't recognize this could be a problem because this file is used for quite some time now. Is this a problem? What do you suggest?
comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
OS X doesn't really use creator codes as its primary means for identifying applications, so you could probably get away with using no creator code at all, or the generic creator code "????". If you want to use a unique creator code for this app, it should be one that's been registered with Apple.
Changed 13 years ago by pusteblumekuchen@…
| Attachment: | Portfile.3 added |
|---|
comment:4 Changed 13 years ago by pusteblumekuchen@…
- The port now uses the generic and default creator code "????"
- I changed the version numbering to the widelands numbering, because it seems to be necessary to use the epoch feature to remove the rc2 ending and it is also possible to use that feature, if a version 1.0 would be released by the widelands-dev team.
- I changed the post-destroot phase to be pre-destroot and create the app layout.
- If there are any more questions or problems, I will try to solve them.
Changed 13 years ago by pusteblumekuchen@…
| Attachment: | Portfile.4 added |
|---|
comment:5 Changed 13 years ago by pusteblumekuchen@…
I added a variant which will build a static linked version of widelands, so it is possible to copy the app bundle to a different computer. This is probably what you would expect from an app bundle.
comment:6 Changed 13 years ago by pusteblumekuchen@…
Updated to the final version. So could this be included into the ports tree?
comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to ryandesign@… |
| Status: | new → assigned |
comment:8 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Added in r92304 with several changes to whitespace and formatting to make it more like other ports.
I removed the "portable" variant; we don't have any such thing in other ports and I don't want to set the precedent now for starting to offer that kind of thing. Software installed by MacPorts is not expected to be relocatable or drag-and-drop installable to other systems. There are other existing mechanisms for redistributing MacPorts-installed software: the binary archives in /opt/local/var/macports/software (for users with MacPorts installed) or the OS X Installer packages created by running "sudo port mpkg" (for those without MacPorts installed). Additionally, there are existing procedures for making an application bundle that contains all its dependencies, for example the software installed by the dylibbundler port.
widelands