Opened 13 years ago
Closed 12 years ago
#34066 closed update (invalid)
gmt4 update to 4.5.8
| Reported by: | florian@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | tenomoto (Takeshi Enomoto) |
| Port: | gmt4, gshhg-gmt-nc4 |
Description
Port gmt4 now depends on port gshhg-gmt-nc4 (#34065).
Attachments (6)
Change History (11)
Changed 13 years ago by florian@…
| Attachment: | patch-bugfixes.diff added |
|---|
comment:2 follow-up: 3 Changed 13 years ago by tenomoto (Takeshi Enomoto)
Sorry for slow response. Your changes seem to be OK but I will have to do two commits: one for the main changes and the other for white space change. BTW where does patch-bugfixes.diff come from? Did you find all the bugs? Usually we create a patch for each file but the problem is that there are so many files to patch. Are the developers going to adopt these patches in the future version (4.5.8.1 or 4.5.9)?
comment:3 Changed 13 years ago by florian@…
Sorry for slow response. Your changes seem to be OK but I will have to do two commits: one for the main changes and the other for white space change.
No worries. I attached two Portfile patches - one for the spacing and one for everything else.
BTW where does patch-bugfixes.diff come from? Did you find all the bugs? Usually we create a patch for each file but the problem is that there are so many files to patch. Are the developers going to adopt these patches in the future version (4.5.8.1 or 4.5.9)?
I'm aware that patch-bugfixes.diff contains quite a lot of hunks. But these are important fixes from svn. They are mostly related to xgrid. I just added xgird as a variant in the reattached Portfile patch. All bugfixes and the changes from patch-gmt_shore_c.diff will be integrated into the next release 4.5.9. Please ignore patch-bugfixes.diff and commit patch-bugfixes-r9794.diff and patch-bugfixes-r9816.diff instead.
comment:4 Changed 12 years ago by jmroot (Joshua Root)
| Cc: | takeshi@… added; takeshi removed |
|---|---|
| Type: | defect → update |
| Version: | 2.0.4 |
comment:5 Changed 12 years ago by tenomoto (Takeshi Enomoto)
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Obsoleted by #37553 .
patchfile 1