Opened 13 years ago

Closed 13 years ago

#34343 closed defect (fixed)

dbus: uses startupitem.install, which fails on MacPorts < 2.1

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: pixilla (Bradley Giesbrecht)
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: Cc: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), mkae (Marko Käning), kk1987@…, jeff.culat@…, machsna (J. ‘mach’ Wust), shawn@…, blair (Blair Zajac), an0nym@…, jean-philippe.humbert@…
Port: dbus

Description

As of r92726 the dbus port already uses the startupitem.install keyword, which does not exist before MacPorts 2.1, therefore, as reported on the mailing list, users of MacPorts < 2.1 encounter an error when trying to use this port, for example:

$ port info dbus
Error: Unable to open port: can't read "startupitem.install": no such variable

If you want to use startupitem.install in the port already, you need to preface any usage of that variable with something like the following so that MacPorts 2.0.x won't fail:

if {[info exists startupitem.install]}

Change History (21)

comment:1 Changed 13 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:2 Changed 13 years ago by kk1987@…

Cc: kk1987@… added

Cc Me!

comment:3 Changed 13 years ago by jeff.culat@…

Cc: jeff.culat@… added

Cc Me!

comment:4 Changed 13 years ago by machsna (J. ‘mach’ Wust)

Cc: j_mach_wust@… added

Cc Me!

comment:5 Changed 13 years ago by shawn@…

Cc: shawn@… added

Cc Me!

comment:6 Changed 13 years ago by nerdling (Jeremy Lavergne)

Priority: HighNormal

Commented out in r92741.

comment:7 Changed 13 years ago by shawn@…

So a fix has been committed, how long does it take before it propagates out to users? Is there a way we can force it? Is there a downside to applying the fix manually?

comment:8 Changed 13 years ago by mkae (Marko Käning)

Try for now simply this:

sudo port upgrade dbus +no_startupitem

This might solve the issue for now without any patches... (Depending on your installation, of course.)

comment:9 Changed 13 years ago by jeff.culat@…

It works for me. Thanks

comment:10 Changed 13 years ago by shawn@…

That workaround also resolves it for me. Thanks!

comment:11 Changed 13 years ago by pixilla (Bradley Giesbrecht)

Ryan: Would a test/set before the first use of startupitem.install be a good solution?

+# The startupitem.install keyword does not exist in MacPorts < 2.1.
+if {![info exists ${startupitem.install}]} {
+    set startupitem.install yes
+}
pre-configure {

comment:12 in reply to:  11 Changed 13 years ago by pixilla (Bradley Giesbrecht)

Correction

+# The startupitem.install keyword does not exist in MacPorts < 2.1.
+if {![info exists startupitem.install]} {
+    set startupitem.install yes
+}
pre-configure {

comment:13 Changed 13 years ago by pixilla (Bradley Giesbrecht)

Has duplicate #34349

comment:14 in reply to:  13 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to pixilla@…:

Has duplicate #34349

Really? That looks like a different error message.

#34348 is a duplicate, though.

Yes, setting startupitem.install to a default value would be fine.

comment:15 Changed 13 years ago by blair (Blair Zajac)

Cc: blair@… added

Cc Me!

comment:16 Changed 13 years ago by pixilla (Bradley Giesbrecht)

See r92760.

I installed MacPorts 2.0.4 and dbus installed with several variant combinations.

Please report success or failure. Thanks.

comment:17 Changed 13 years ago by an0nym@…

Cc: an0nym@… added

Cc Me!

comment:18 Changed 13 years ago by jean-philippe.humbert@…

Cc: jean-philippe.humbert@… added

Cc Me!

comment:19 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Has duplicate #34360.

comment:20 in reply to:  16 Changed 13 years ago by pixilla (Bradley Giesbrecht)

Replying to pixilla@…:

See r92760.

I installed MacPorts 2.0.4 and dbus installed with several variant combinations.

Please report success or failure. Thanks.

Any feedback? r92760 should fix this.

comment:21 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

dbus no longer uses startupitem.install when it's not defined, which is what I filed this ticket about. I verified the port builds fine with MacPorts 2.0.4 and 2.1 beta 1, so I'm calling it resolved.

There is a remaining issue for users using the binary; see #34349.

Note: See TracTickets for help on using tickets.