Opened 12 years ago

Closed 12 years ago

#34623 closed defect (fixed)

isl configure script is still incorrect

Reported by: jeremyhu (Jeremy Huddleston Sequoia) Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 2.1.1
Keywords: Cc:
Port: isl

Description

You patched the m4 macro and forgot to run autoreconf, then you patched configure directly but didn't match the changes to the m4 macro (#34489). This should be the correct fix:

Index: files/patch-configure.diff
===================================================================
--- files/patch-configure.diff	(revision 93521)
+++ files/patch-configure.diff	(working copy)
@@ -1,11 +0,0 @@
---- configure.orig	2012-05-20 08:17:05.000000000 -0700
-+++ configure	2012-05-20 08:17:22.000000000 -0700
-@@ -15793,7 +15793,7 @@
- Description: @PACKAGE_DESCRIPTION@
- Version: @PACKAGE_VERSION@
- Requires: @PACKAGE_REQUIRES@
--Libs: -L\${libdir} @LDFLAGS@ @LIBS@
-+Libs: -L\${libdir} @LIBS@
- Cflags: -I\${includedir} @CPPFLAGS@
- AXEOF
- fi # DONE generate $pkgconfig_generate.in
Index: Portfile
===================================================================
--- Portfile	(revision 93521)
+++ Portfile	(working copy)
@@ -6,7 +6,7 @@
 
 name                isl
 version             0.07
-revision            1
+revision            2
 epoch               1
 categories          devel math
 
@@ -28,9 +28,11 @@
 use_bzip2           yes
 
 # See http://groups.google.com/group/isl-development/t/37ad876557e50f2c
-patchfiles          patch-ax_create_pkgconfig_info.m4.diff \
-                    patch-configure.diff
+patchfiles          patch-ax_create_pkgconfig_info.m4.diff
 
+use_autoreconf      yes
+autoreconf.args     -fvi
+
 checksums           rmd160  bded741256ad5510d43542775673e3b383c1e30e \
                     sha256  ddcf3fa454c98d0c657a4474c194ba07eb197b72f263a7307ebe719ee1aefd4e
 

Change History (1)

comment:1 Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Resolution: fixed
Status: newclosed

Thank you for the patch.
Applied in r93580.

Note: See TracTickets for help on using tickets.