Opened 12 years ago
Closed 12 years ago
#34659 closed update (fixed)
py-geoip @1.2.7 update
| Reported by: | lockhart (Thomas Lockhart) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | pixilla (Bradley Giesbrecht), miwi@… | |
| Port: | py-geoip |
Description
Python-GeoIP has a new release available. This has been available since August 2011 so this port perhaps should be considered unmaintained. The current set of ports (py-geoip, py25-geoip, py26-geoip, py27-geoip) do not build since they assume C header files are in /usr/local, not /opt/local. This patch set replaces all of the current version-specific portfiles with a single Portfile to be installed in python/py-geoip/.
Attachments (2)
Change History (11)
comment:1 follow-up: 2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | miwi@… added |
|---|
comment:2 Changed 12 years ago by lockhart (Thomas Lockhart)
Replying to ryandesign@…:
Thanks.
We probably don't need all those ui_debugs.
I'm surprised setting build.env was necessary. Are you sure it is?
Note that examples belong in ${prefix}/share/examples/${subport}.
The build.env was a holdover from the previous portfile. Since someone else is maintaining this, I didn't want to poke at everything. But I agree the environment variables did not seem to be helpful. Not sure how to get those examples installed elsewhere; this is where they show up when the code tries to build. Will look at it.
comment:3 Changed 12 years ago by lockhart (Thomas Lockhart)
OK, I've removed the extraneous environment variables (CCFLAGS etc) and removed the ui_debug statements. Builds and installs without error on my Lion machine.
Changed 12 years ago by lockhart (Thomas Lockhart)
Full portfile to upgrade version, fix broken port, and use subports for various python versions.
comment:4 follow-ups: 6 8 Changed 12 years ago by jmroot (Joshua Root)
| Keywords: | haspatch removed |
|---|---|
| Version: | 2.1.1 |
comment:5 Changed 12 years ago by jmroot (Joshua Root)
| Summary: | py-geoip @1.2.7 update release, fix broken port, and use subports → py-geoip @1.2.7 update |
|---|
comment:6 Changed 12 years ago by lockhart (Thomas Lockhart)
Replying to jmr@…:
The header issue is #32628 and was fixed in r95185, which also unified the ports. Can you please attach a unified diff against the current portfile, without whitespace changes?
OK, if I can figure out what is different now. What is the concern over whitespace? afaict there are several lines with tab issues; not sure what the guidelines should be when modifying or adding a line. So far I've been using other Portfile examples as a guide.
comment:7 Changed 12 years ago by mf2k (Frank Schima)
The reason we want to see a diff is so we can see the actual changes you are making. If you include whitespace changes, then it's harder to see the actual differences. We like whitespace fixes, but not combined with functional changes. Doing it this way makes contributed patches more likely to get committed and sooner. Thanks!
Changed 12 years ago by lockhart (Thomas Lockhart)
| Attachment: | Portfile.diff added |
|---|
Update the GeoIP version to 1.2.7. Add a livecheck test. Patch is on current svn contents.
comment:8 Changed 12 years ago by lockhart (Thomas Lockhart)
Replying to jmr@…:
The header issue is #32628 and was fixed in r95185, which also unified the ports. Can you please attach a unified diff against the current portfile, without whitespace changes?
OK, done. Look for Portfile.diff in the attachments. Will open an issue fixing up whitespace after the next subversion update in whatever form it takes.
comment:9 Changed 12 years ago by pixilla (Bradley Giesbrecht)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Taking advantage of maintainer timeout.
See r97137
Thanks.
We probably don't need all those ui_debugs.
I'm surprised setting build.env was necessary. Are you sure it is?
Note that examples belong in ${prefix}/share/examples/${subport}.