VLC @2.0.1_0 fails to upgrade on OS X 10.6.

[nonstop.server@…]

VLC fails to upgrade from version 2.0.1_0 to 2.0.1_3 on OS X 10.6.

:info:build   OBJC     libmacosx_plugin_la-about.lo
:info:build 1 warning generated.
:info:build   OBJC     libmacosx_plugin_la-applescript.lo
:info:build clang: warning: argument unused during compilation: '-fobjc-exceptio
ns'
:info:build clang: warning: argument unused during compilation: '-ffast-math'
:info:build clang: warning: argument unused during compilation: '-funroll-loops'
:info:build clang: warning: argument unused during compilation: '-fobjc-exceptions'
:info:build clang: warning: argument unused during compilation: '-ffast-math'
:info:build clang: warning: argument unused during compilation: '-funroll-loops'
:info:build about.m:98:60: error: use of undeclared identifier '__clang_version__'
:info:build         compiler = [NSString stringWithFormat:@"clang %s", __clang_version__];
:info:build                                                            ^
:info:build 1 error generated.
:info:build make[6]: *** [libmacosx_plugin_la-about.lo] Error 1
:info:build make[6]: *** Waiting for unfinished jobs....

Version Information:

Mac OS Version:
Darwin 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386

Xcode Version:
Xcode 3.2.3
Component versions: DevToolsCore-1691.0; DevToolsSupport-1591.0
BuildVersion: 10M2262

Macports Version:
Version: 2.1.1

clang Version:
% whence clang ;$(whence clang) --version
/usr/bin/clang
Apple clang version 1.5 (tags/Apple/clang-60)
Target: x86_64-apple-darwin10
Thread model: posix

I can confirm that the same upgrade was performed without any issues on OS X 10.5 and OS X 10.7.

[jeremyhu (Jeremy Huddleston Sequoia)]

You really should upgrade to XCode 3.2.6. 3.2.3 isn't supported, but I'll put in a patch nonetheless.

r93899

[nonstop.server@…]

Replying to jeremyhu@…:

Thank you for the patch and your advice.
However the upgrade did not work with the patch from r93899.
I have attached the log of this attempt also.
Do you want to give the patch another try, fixing compilation with XCode 3.2.3? I'm willing to test it before I upgrade to XCode version 3.2.6.
If not let me know, so I can upgrade my XCode to the suggested version.

[jeremyhu (Jeremy Huddleston Sequoia)]

Well, that's a different error:

:info:build ncurses.c:649:23: error: read-only variable is not assignable
:info:build             wide[i  ] = '.';
:info:build             ~~~~~~~~~ ^
:info:build ncurses.c:650:23: error: read-only variable is not assignable
:info:build             wide[i+1] = '.';
:info:build             ~~~~~~~~~ ^
:info:build ncurses.c:655:27: error: read-only variable is not assignable
:info:build                 wide[i-1] = '.';
:info:build                 ~~~~~~~~~ ^
:info:build ncurses.c:670:46: error: read-only variable is not assignable
:info:build             wide[i + 2 + i_char_len - j - 1] = '\0';
:info:build             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
:info:build ncurses.c:676:17: error: read-only variable is not assignable
:info:build         wide[i] = '\0';
:info:build         ~~~~~~~ ^

and wide is declared as:

wchar_t wide[len + 1];

So it's a compiler bug. Please update to a supported XCode version.

[nonstop.server@…]

Replying to jeremyhu@…:

Thank you for troubleshooting and your swift reply.