#34911 closed enhancement (fixed)
nginx @1.2.1 Attempting to add uploadprogress variant
Reported by: | mitch@… | Owned by: | neverpanic (Clemens Lang) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.1.1 |
Keywords: | haspatch | Cc: | |
Port: | nginx |
Description
Hi Cal and Openmaintainer :-)
Attached is a diff with the latest Portfile from nginx@1.2.1, where I try to add a variant for Bricy Figureau's upload progress module.
I managed to figure out how to add the download URL, as well as the initial variant block. What I cannot solve is a configure error, and I'm pretty sure I am doing something wrong.
As a total macports n00b I'll do whatever you guys tell me to, I gotta get this module in or life becomes too difficult when there are updates to nginx. Can you please tell me where to look so I can try to fix this up?
Attachments (1)
Change History (5)
Changed 12 years ago by mitch@…
Attachment: | uploadprogress_module.diff added |
---|
comment:1 Changed 12 years ago by neverpanic (Clemens Lang)
Component: | server/hosting → ports |
---|---|
Owner: | changed from wsiegrist@… to cal@… |
Port: | nginx added |
Status: | new → assigned |
comment:2 Changed 12 years ago by neverpanic (Clemens Lang)
Keywords: | haspatch added |
---|
comment:3 Changed 12 years ago by neverpanic (Clemens Lang)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Commited in r94452 with the following changes:
- Renamed all variables to
uploadprg_*
to avoid conflicts with theupload
variant - Added
post-extract
phase to rename the extracted directory to the name expected passed toconfigure
.
comment:4 Changed 12 years ago by mitch@…
Cal, I owe you a very large glass of your favorite if you ever find your way to Italy. You got no idea what kind of pain this fix brings to an end, a thousand thanks! You da man!
My feeble attempt at adding a new variant to nginx Portfile