mogenerator Portfile

[public@…]

this is a Portfile for mogenerator, a quite useful tool for Mac/iOS developers. I

​http://rentzsch.github.com/mogenerator/

[ryandesign (Ryan Carsten Schmidt)]

Some initial observations:

• Delete the name and version lines; that's part of what the github.setup line does for you automatically
• As "port lint" will tell you, the maintainers line should be obfuscated (host:user)
• As "port lint" will tell you, "configure {}" should be changed to "use_configure no"
• As "port livecheck" will tell you, "git" is not a valid livecheck.type
• Does this port really use git-core at build time and at runtime?
• Have you considered using the xcode portgroup?
• Please change the whitespace of the portfile to conform to the modeline (indentations at multiples of 4 spaces)

[public@…]

• Delete the name and version lines; that's part of what the github.setup line does for you automatically
• As "port lint" will tell you, the maintainers line should be obfuscated (host:user)
• As "port lint" will tell you, "configure {}" should be changed to "use_configure no"
• As "port livecheck" will tell you, "git" is not a valid livecheck.type
• Please change the whitespace of the portfile to conform to the modeline (indentations at multiples of 4 spaces)
• Have you considered using the xcode portgroup?

done

I guess the "lint" part should be mentioned on the docs? ​http://guide.macports.org/chunked/project.contributing.html

• Does this port really use git-core at build time and at runtime?

The port only needs git-core for cloning out of github, but because of your comment I assume that the github porgroup also takes care of that

I have just attached Portfile.2 to the ticket

There is also one extra modification I made, which should not be a big deal. In the first line, along the Vim parameters I set the portfile syntax as filetype, and not "tcl"

[ryandesign (Ryan Carsten Schmidt)]

If you set fetch.type to git, then MacPorts base (not the github portgroup) automatically adds port:git as a fetch dependency.

However in this port the fetch.type is not set to git, and git is not used at all to fetch the source (nor should it be). This port fetches a regular tarball, like other normal ports. It just happens to fetch that tarball from a hosting service called github.

[ryandesign (Ryan Carsten Schmidt)]

Thanks; I committed it in r97120. I removed "use_configure no" because that is the default when using the xcode portgroup. I rearranged the lines of the portfile to match other ports. I added code to the destroot block to install the README file.

I guess the Contributing page in the Guide assumes you already have a complete Portfile submission or update to contribute, and assumes you have also read the rest of the Guide; lint is mentioned in the Guide ​here.