Opened 12 years ago
Closed 12 years ago
#35295 closed submission (fixed)
cputhrottle @1.0 - new port
| Reported by: | icaines77@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.1 |
| Keywords: | Cc: | nonstop.server@… | |
| Port: | cputhrottle |
Description
Program for throttling the cpu usage for specific processes.
Attachments (4)
Change History (11)
Changed 12 years ago by icaines77@…
Changed 12 years ago by icaines77@…
| Attachment: | makefile.diff added |
|---|
comment:1 Changed 12 years ago by icaines77@…
Sorry, this is building correctly but fails when run, I'll take a closer look.
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Port: | cputhrottle added |
|---|
comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Some initial observations:
- Setting distfiles and worksrcdir are unnecessary when you have already set distname.
- Setting revision 0 is unnecessary; that's the default.
- "none" is not a valid maintainer; perhaps you mean "nomaintainer".
- Since this has no configure script, you must manually ensure you're UsingTheRightCompiler and -arch flags and if possible add a universal variant.
Changed 12 years ago by icaines77@…
| Attachment: | makefile.2.diff added |
|---|
Revised makefile patch so compiler variable is taken from environment.
comment:4 Changed 12 years ago by icaines77@…
Thanks for taking a look. I've attached a revised portfile and patch that address your observations. Not 100% sure on your last point, since "get_canonical_archflags" isn't in the documentation, but I see that it's what other ports do in similar situations.
Re my previous comment re failing on run: I think would be tricky to get around having to run this as root.
comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Thanks. Committed in r95892 with these changes:
- added standard modeline and adjusted some whitespace and formatting
- rather than assigning a random version number of "1.0", I thought it would be better to set the version number to the release date, as determined by the HTTP Last-Modified header of the cputhrottle.tar.gz source file
- eliminated the need for the patchfile (although some of the changes you made in the patchfile would be good for the developer to include in his sources, and you should send those modifications to him for inclusion)
- used dist_subdir because this is an unversioned distfile
- changed boost from a library dependency to a build dependency, per the developer's web site and my own observation with "otool -L"
- added a note explaining to the user that they must run the program as root (this is confirmed by the developer's web site)
Note: See
TracTickets for help on using
tickets.
Fix makefile to work with macports.