#35354 closed defect (fixed)
Dosbox disable 64bit until next version
| Reported by: | domiman@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | Cc: | royliu@…, ryandesign (Ryan Carsten Schmidt) | |
| Port: | dosbox |
Description
Dosbox 0.74 still crashes when built in 64bit as soon as Dosbox switches core to dynamic. To test just run
core dynamic
in Dosbox.
This is resolved in SVN of Dosbox and thus should be working whenever a new version is out.
So please make it 32bit only again until then.
I'm CCing Royliu because he changed it to 64bit.
Later in the summer I'll volunteer for port maintainer of Dosbox. Since I know the ins and outs of it and are maintaining SVN binary snapshots anyway I can do the port as well :)
Attachments (1)
Change History (8)
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added |
|---|
comment:2 Changed 12 years ago by domiman@…
The problem is that even when the crash is fixed, core dynamic on 64bit is way less efficient and is at about only 20-50% of the speed than on 32bit. And this likely won't change since this is just the nature of the 64bit dynamic core :( (not to mention that current SVN of Dosbox is broken again and the 64bit built is at only 1% speed of the 32bit built :) - I volunteered for the dosbox defs to find the culprit but haven't had time to do so)
Since DOS emulation needs a lot of speed for "newer" old DOS games this is the reason I'd never recommend a 64bit built of Dosbox.
comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to domiman@…:
The problem is that even when the crash is fixed, core dynamic on 64bit is way less efficient and is at about only 20-50% of the speed than on 32bit. And this likely won't change since this is just the nature of the 64bit dynamic core :( (not to mention that current SVN of Dosbox is broken again and the 64bit built is at only 1% speed of the 32bit built :) - I volunteered for the dosbox defs to find the culprit but haven't had time to do so)
Since DOS emulation needs a lot of speed for "newer" old DOS games this is the reason I'd never recommend a 64bit built of Dosbox.
I see. I was going on your comment above:
Replying to domiman@…:
This is resolved in SVN of Dosbox and thus should be working whenever a new version is out.
You didn't mention that it was also slower and that this was not yet fixed. Given this new information, I now agree disabling the 64-bit build would be a good idea. However, it does not build 32-bit for me. My log is attached.
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
comment:4 Changed 12 years ago by domiman@…
I think I encountered this as well and solved this by compiling it with gcc-4.2
comment:5 Changed 12 years ago by domiman@…
When I wrote that it is resolved I forgot that it is so much slower. And only then I found out that it is speedwise even more broken now. Sorry
comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Thanks. gcc is not included with Xcode anymore, but using llvm-gcc worked for me, so that's what's in r97579 now.
comment:7 Changed 12 years ago by jmroot (Joshua Root)
Is there an upstream bug report about the bad asm? If not, there should be.
Rather than disabling the 64-bit build, we could make a patch using the upstream fix. It appears to be upstream revision r3674. I added this to the port in r97574; "core dynamic" no longer crashes now. Does this work for you as well?