Opened 12 years ago

Closed 12 years ago

#35479 closed defect (fixed)

Inkscape 0.48.3.1_1: patch file for poppler 0.20.2 includes hard-coded prefix "/opt/local"

Reported by: su-v Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch Cc:
Port: inkscape

Description

Upgrading Inkscape after recent rev bump for poppler 0.20.2 fails if MacPorts was installed into a custom prefix:

:info:build   CXX    extension/internal/pdfinput/svg-builder.o
:info:build   CXX    extension/internal/pdfinput/pdf-parser.o
:info:build extension/internal/pdfinput/pdf-parser.cpp:41:47: error: /opt/local/include/poppler/Object.h: No such file or directory
:info:build   CXX    extension/internal/pdfinput/pdf-input.o
:info:build   CXX    extension/internal/filter/filter-all.o
:info:build make[2]: *** [extension/internal/pdfinput/pdf-parser.o] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....
:info:build extension/internal/pdfinput/svg-builder.cpp: In member function ‘std::string Inkscape::Extension::Internal::SvgBuilder::_BestMatchingFont(std::string)’:
:info:build extension/internal/pdfinput/svg-builder.cpp:907: warning: comparison is always false due to limited range of data type
:info:build extension/internal/pdfinput/svg-builder.cpp:912: warning: comparison between signed and unsigned integer expressions
:info:build extension/internal/pdfinput/svg-builder.cpp: In member function ‘Inkscape::XML::Node* Inkscape::Extension::Internal::SvgBuilder::_createImage(Stream*, int, int, GfxImageColorMap*, int*, bool, bool)’:
:info:build extension/internal/pdfinput/svg-builder.cpp:1444: warning: ‘jmpbuf’ is deprecated (declared at /Volumes/cyan/mp-quartz/with-a-long-long-long-directory-name/include/png.h:1123)
:info:build extension/internal/pdfinput/svg-builder.cpp:1444: warning: ‘jmpbuf’ is deprecated (declared at /Volumes/cyan/mp-quartz/with-a-long-long-long-directory-name/include/png.h:1123)
:info:build make[2]: Leaving directory `/Volumes/cyan/mp-quartz/with-a-long-long-long-directory-name/var/macports/build/_Volumes_cyan_mp-quartz_src_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1/src'
:info:build make[1]: *** [all-recursive] Error 1
:info:build make[1]: Leaving directory `/Volumes/cyan/mp-quartz/with-a-long-long-long-directory-name/var/macports/build/_Volumes_cyan_mp-quartz_src_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/Volumes/cyan/mp-quartz/with-a-long-long-long-directory-name/var/macports/build/_Volumes_cyan_mp-quartz_src_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1'
:info:build Command failed:  cd "/Volumes/cyan/mp-quartz/with-a-long-long-long-directory-name/var/macports/build/_Volumes_cyan_mp-quartz_src_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1" && /usr/bin/make -j4 -w all 
:info:build Exit code: 2
:error:build org.macports.build for port inkscape returned: command execution failed

#include "Object.h" in src/extension/internal/pdfinput/pdf-parser.cpp doesn't need to be modified in the patch file, since the post-patch phase will insert the full path (using the current prefix) to the referenced header file.

Build tested successfully with attached modified version of the patch file 'patch-src-extension-internal-pdfinput-pdf-parser.cpp.diff', using MacPorts 2.1.2 on OS X 10.7.4 (Xcode 4.3.2).

Attachments (1)

patch-src-extension-internal-pdfinput-pdf-parser.cpp.diff (19.6 KB) - added by su-v 12 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: devans@… removed
Keywords: haspatch added; prefix removed
Owner: changed from macports-tickets@… to devans@…

comment:2 Changed 12 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

r98277 (maintainer timeout)

Note: See TracTickets for help on using tickets.