Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#35862 closed update (fixed)

dmd, dmd-tools, druntime, phobos: update to 2.060; simplify

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: tenomoto (Takeshi Enomoto)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch Cc: cooljeanius (Eric Gallager)
Port: dmd, dmd-tools, druntime, phobos

Description

These patches update dmd and druntime to 2.060 and simplify them by removing directives that the github portgroup makes unnecessary.

For druntime I also removed a reinplace that didn't seem to do anything (in this version anyway).

These patches are untested because this version of dmd fails to build for me just like the previous version did. If the previous version built for you, this version might too.

Attachments (3)

dmd-2.060.diff (1.2 KB) - added by ryandesign (Ryan Carsten Schmidt) 12 years ago.
phobos-2.060.diff (1.5 KB) - added by ryandesign (Ryan Carsten Schmidt) 12 years ago.
druntime-2.060.diff (1.5 KB) - added by ryandesign (Ryan Carsten Schmidt) 12 years ago.

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: dmd-2.060.diff added

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Port: dmd-tools phobos added
Summary: dmd, druntime: update to 2.060; simplifydmd, dmd-tools, druntime, phobos: update to 2.060; simplify

And phobos and dmd-tools. For phobos I also removed an unused reinplace.

dmd-tools was not using the github portgroup yet. I tried to convert it to do so, but it is complicated because it wants to download a distfile from the "tools" project and another distfile from the "d-programming-language.org" project. Is this necessary? If we could separate this into two ports, each of which would deal with only one distfile, that would make things much simpler.

Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: phobos-2.060.diff added

Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: druntime-2.060.diff added

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Now dmd has already been updated to 2.060 in r97147, so the changes to dmd's distname should wait until the next version is released, so that users and our mirror servers don't have to download the same distfile again under a different name.

comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Never mind, I see you just committed it in r97148. :)

comment:4 Changed 12 years ago by tenomoto (Takeshi Enomoto)

I committed the patches in r97148. The additional distfile contains documentation, which can be a separate port. How can I use a port name different from the one in github.setup?

comment:5 Changed 12 years ago by tenomoto (Takeshi Enomoto)

I updated dmd-tools to 2.060 in r97636. tools except for dman could be separated, but dman needs files generated from doc. I don't have any idea how to separate the two to use github portgroup at this time.

comment:6 in reply to:  4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to takeshi@…:

How can I use a port name different from the one in github.setup?

Write your own name line right after the github.setup line.

comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

dmd-tools is now using the github portgroup, but could still use further cleanup, such as:

  • remove the dlang variable since you already have the github.author variable with the same value
  • remove the realname variable and just set it directly in the github.setup line; then you can use the github.project variable wherever else you need it
  • remove the foreach loop in the destroot block; use eval xinstall -W instead
  • use system -W ... "..." instead of system "cd ...; ..."

comment:8 Changed 12 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: newclosed

Thanks for your comments. Now Portfile looks much neater in r105209 (dmd-tools) and in r105210 (phobos) than in r105204. I close this ticket now.

comment:9 Changed 12 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

Note: See TracTickets for help on using tickets.