Opened 12 years ago
Closed 12 years ago
#35872 closed update (fixed)
git-flow: update to use github PortGroup
Reported by: | gorticus (Jason Mitchell) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch maintainer | Cc: | |
Port: | git-flow |
Description
Few Portfile
updates:
- use
PortGroup github
- add
openmaintainer
(so I don't slow things down) - submodule update to single git command
As a question, has anyone considered making --recursive
a default option on the git clone
to address submodule
captures?
Attachments (2)
Change History (6)
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Changed 12 years ago by gorticus (Jason Mitchell)
Attachment: | Portfile-git-flow added |
---|
Changed 12 years ago by gorticus (Jason Mitchell)
Attachment: | Portfile-git-flow.diff added |
---|
comment:2 Changed 12 years ago by gorticus (Jason Mitchell)
Suggestions 1 & 2 corrected and attachments replaced.
comment:3 follow-up: 4 Changed 12 years ago by gorticus (Jason Mitchell)
Regarding the git fetch, in portfetch.tcl
, git.*
does not have default argument elements, e.g. svn.pre_args
, and it seems that portfetch::gitfetch()
does not use the input args
. It would seem that it would be necessary to add at least a default git.clone_args ""
and modify portfetch::gitfetch()
's cmdstring
to be something like: set cmdstring "${git.cmd} clone ${git.clone_args} $options ...
.
Since the --recursive
option seems to be harmless if there are no submodules, perhaps it's easier to just set options "-q --recursive"
?
This has probably reached the level of a separate enhancement request, yes? Shall I put it in?
comment:4 Changed 12 years ago by neverpanic (Clemens Lang)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Replying to jason-macports@…:
This has probably reached the level of a separate enhancement request, yes? Shall I put it in?
Yes, please.
Commited in r97786.
A couple comments:
universal_variant no
"; it's implied by "supported_archs noarch
".homepage http://github.com/nvie/gitflow
"; the github portgroup does that for you.--recursive
" wouldn't be something the github portgroup would do for you since I assume that option is not specific to the github hosting service but is general to any server hosting git repositories; if anything, it would be an option we could add to MacPorts base—assuming the existing means of adding arguments to commands is insufficient for that purpose.