Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#35925 closed defect (fixed)

port lint inaccurately complains about port directory name when a full @macports.org maintainer address is used

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone: MacPorts 2.1.3
Component: base Version: 2.1.2
Keywords: Cc:
Port:

Description

$ port lint XXX
--->  Verifying Portfile for XXX
Warning: Using full email address for no/open maintainer
Error: Portfile directory XXX does not match port name nomaintainer
--->  1 errors and 1 warnings found.

The warning is correct, but the error is not; the problem is that the "name" variable (which is supposed to represent the port name) got overwritten with the local part of the maintainer email address being checked.

The fix is to change the variable "name" to something else (such as "localpart") in the following lines in src/port1.0/portlint.tcl:

        } elseif [regexp "^(.+)@macports.org$" $addr -> name] {
            ui_warn "Maintainer email address for $name includes @macports.org"

Change History (2)

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

comment:2 Changed 12 years ago by jmroot (Joshua Root)

Milestone: MacPorts 2.1.3
Note: See TracTickets for help on using tickets.