fox build failure with libpng @1.5.12

[jjstickel (Jonathan Stickel)]

Looks like fox is also experiencing a build error with libpng-1.5.12. From the build log:

:info:build fxpngio.cpp:78:18: error: member access into incomplete type 'png_struct' (aka 'png_struct_def')
:info:build   longjmp(png_ptr->jmpbuf,1);                           // Bail out
:info:build                  ^
:info:build /opt/local/include/png.h:854:16: note: forward declaration of 'png_struct_def'
:info:build typedef struct png_struct_def png_struct;
:info:build                ^
...

See also #35945, #35948, #35949.

[ryandesign (Ryan Carsten Schmidt)]

The fox port is at version 1.6.36. According to the ​fox toolbox news page, libpng 1.5 compatibility was added in fox 1.6.42, so we should update the port. The current version of fox is 1.6.46.

The attached patch updates fox to 1.6.46; removes the redundant distname line; indicates the license; fixes the master_sites; uses modern checksum types; removes unneeded or unsupported configure args; adds freetype CPPFLAGS now needed by this version; and fixes the livecheck. May I commit it?

[ryandesign (Ryan Carsten Schmidt)]

proposed patch

[jmroot (Joshua Root)]

r98502

[ryandesign (Ryan Carsten Schmidt)]

Replying to jmr@…:

r98502

That didn't include all the changes in my patch.

mww added the license in r98503, but set it to LGPL-3; the LICENSE file says LGPL 2.1 and the source files say "or any later version". The ​web site reproduces the text of the LGPL 3.

I committed the rest of my patch in r98818.