rxvt build fails silently

[eradicator@…]

On MacOS X 10.4, rxvt fails to build, but make's exit code does not report this failure, so the result is rxvt merging but no rxvt executable.

I/usr/X11R6/include -I.. -I. -I. -c graphics.c -o graphics.o graphics.c: In function 'rxvt_Gr_Text': graphics.c:158: warning: pointer targets in passing argument 2 of 'XTextWidth' iffer in signedness graphics.c:160: warning: pointer targets in passing argument 2 of 'XTextWidth' iffer in signedness graphics.c:176: warning: pointer targets in passing argument 6 of 'XDrawString' differ in signedness echo timestamp > graphics.lo /bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -no-cpp-precomp -I/usr/ 11R6/include -g -O2 -DDEBUG_STRICT -I/usr/X11R6/include -I.. -I. -I. -c lo ging.c gcc -DHAVE_CONFIG_H -no-cpp-precomp -I/usr/X11R6/include -g -O2 -DDEBUG_STRICT I/usr/X11R6/include -I.. -I. -I. -c logging.c -o logging.o logging.c: In function 'rxvt_makeutent': logging.c:140: error: 'struct utmpx' has no member named 'ut_session' logging.c:206: error: 'RXVT_WTMPX_FILE' undeclared (first use in this function) logging.c:206: error: (Each undeclared identifier is reported only once logging.c:206: error: for each function it appears in.) logging.c: In function 'rxvt_cleanutent': logging.c:257: error: 'struct utmpx' has no member named 'ut_session' logging.c:278: error: 'RXVT_WTMPX_FILE' undeclared (first use in this function) make[1]: * [logging.lo] Error 1 /usr/bin/tbl ./rxvt.tbl | grep -v '^{.lf' > rxvt.1 make[1]: Nothing to be done for `all'. make[1]: Nothing to be done for `all'. make[1]: Nothing to be done for `all'. ---> Staging rxvt into destroot}

[olegb@…]

I can reproduce this error. But, i still get a functional rxvt.

m00:~/HEAD/dports/x11/rxvt olegb$ port installed rxvt The following ports are currently installed: rxvt 2.7.10_1 (active) m00:~/HEAD/dports/x11/rxvt olegb$ which rxvt /opt/local/bin/rxvt m00:~/HEAD/dports/x11/rxvt olegb$ port contents rxvt | grep rxvt Port rxvt contains: /opt/local/bin/rxvt /opt/local/bin/rxvt-2.7.10 /opt/local/share/man/man1/rxvt.1.gz m00:~/HEAD/dports/x11/rxvt olegb$

[olegb@…]

I have commited a fix that doesnt break the tiger build.