Opened 12 years ago
Closed 12 years ago
#36260 closed enhancement (fixed)
TOra: switch no_oracle variant to oracle variant, and enforce 32-bit mode on Lion and up
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | petr@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.1.2 |
Keywords: | haspatch | Cc: | |
Port: | TOra |
Description
Here's a patch for TOra. The patch does two things:
First, it changes the port's no_oracle variant into an oracle variant. We don't like using variants whose names begin with "no_" anymore, now that MacPorts has the ability to remember disabled variants. A stub no_oracle variant remains to help existing users upgrade; it can be removed in a year or so once most users can be expected to have upgraded.
Second, oracle-instantclient crashes in 64-bit mode on Lion and up; see #31521. Therefore this patch makes the port build in 32-bit mode in that case. I'm going to be doing similar patches for all the other ports that use oracle-instantclient.
Let me know if the patch looks ok to you and I'll commit it.
Attachments (1)
Change History (3)
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
comment:1 Changed 12 years ago by pvanek@…
yep, it seems fine to me. Thanks. Unfortunately I cannot test it because I'm on Snow Leopard still.
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | new → closed |
I verified that TOra crashes when it is run in 64-bit mode on Mountain Lion, but not in 32-bit mode. So I committed it in r98249.
proposed patch