#36383 closed update (fixed)
moin: update to 1.9.5 and python27
| Reported by: | mndavidoff (Monte Davidoff) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | mf2k (Frank Schima), ryandesign (Ryan Carsten Schmidt) |
| Port: | moin |
Description
The attached patch updates moin to 1.9.5 and to use python27. Thanks!
Attachments (5)
Change History (13)
Changed 12 years ago by mndavidoff (Monte Davidoff)
| Attachment: | Portfile.diff added |
|---|
comment:1 Changed 12 years ago by mf2k (Frank Schima)
| Version: | 2.1.2 |
|---|
comment:2 Changed 12 years ago by mndavidoff (Monte Davidoff)
Good idea. A pyXY-moin port would also be easier to use because you can select the version of Python you want. I've attached Portfiles and diffs that obsolete the port www/moin (Portfile.moin, Portfile.moin.diff) and creates the unified port python/py-moin (Portfile.py-moin, Portfile.py-moin.diff).
Changed 12 years ago by mndavidoff (Monte Davidoff)
| Attachment: | Portfile.moin added |
|---|
Changed 12 years ago by mndavidoff (Monte Davidoff)
| Attachment: | Portfile.moin.diff added |
|---|
comment:3 Changed 12 years ago by mf2k (Frank Schima)
The new py-moin port looks mostly good, with a minor tweak to use "categories-append www". But shouldn't we call it py-moinmoin?
Changed 12 years ago by mndavidoff (Monte Davidoff)
| Attachment: | Portfile.py-moin added |
|---|
Changed 12 years ago by mndavidoff (Monte Davidoff)
| Attachment: | Portfile.py-moin.diff added |
|---|
comment:4 Changed 12 years ago by mndavidoff (Monte Davidoff)
Thank you for reviewing these changes! I've replaced the Portfile.py-moin and Portfile.py-moin.diff attachments with new versions that use "categories-append www". When the moin setup.py script calls the setup function, it specifies the name of the package as "moin", so I think it would be more consistent to call the port py-moin instead of py-moinmoin.
comment:5 Changed 12 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Sorry for the delay. r98783.
comment:7 follow-up: 8 Changed 12 years ago by mndavidoff (Monte Davidoff)
Thank you! I noticed one little nit: the $Id$ keyword did not expand properly to reflect the current revision in the python/py-moin Portfile. Could you please fix that too? I had accidentally attached a new Portfile with an old, expanded $Id$.
comment:8 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | macsforever2000@… ryandesign@… added |
|---|
Replying to macsforever2000@…:
Sorry for the delay. r98783.
You should have used svn cp to copy the old portfile to the new one. That would have preserved the svn properties, not to mention the port's history.
Replying to macsforever2000@…:
moin port updated/replaced_by in r98784.
You need to increase the revision or version when marking a port replaced_by another, otherwise users who had the old port installed will not be aware of the available update. Fixed in r99231.
Replying to md14-macports@…:
Thank you! I noticed one little nit: the $Id$ keyword did not expand properly to reflect the current revision in the python/py-moin Portfile. Could you please fix that too? I had accidentally attached a new Portfile with an old, expanded $Id$.
I fixed the svn properties on this and other new ports in r99134 and r99135.
This port should no longer use the old pythonX.Y portgroups. In fact, maybe this port should be renamed to pyXY-moin?