Opened 12 years ago
Closed 12 years ago
#36404 closed defect (fixed)
bob: use github portgroup
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | andre.anjos@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | haspatch | Cc: | laurent.el-shafey@…, ci42 |
| Port: | bob |
Description
This patch updates bob to use the github portgroup. If you have no objections, I can commit it.
There was some back and forth in #36130 about whether the github portgroup should be used. The specific improvement this would offer is that the livecheck would be fixed.
Before:
$ port livecheck Error: cannot check if bob was updated (regex didn't match) $
After:
$ port livecheck $
Attachments (1)
Change History (5)
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | bob-github-portgroup.diff added |
|---|
comment:1 Changed 12 years ago by andre.dos.anjos@…
Please go ahead and commit this patch. Thanks, A
comment:3 Changed 12 years ago by ci42
The github portgroup does the livecheck on the tags, not on the download page/distributed sources. If there (always) will be a corresponding release for a tag, fine. Otherwise I would opt for a custom livehcheck on https://github.com/idiap/bob/wiki/Releases or https://github.com/idiap/bob/downloads.
@Ryan: Maybe we could improve the github portgroup to handle cases like this (using the github download site(s)) more easily?
comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The github portgroup is now being used in the bob port as of r98470. It now fetches its distfile from tags as well, not downloads, so the livecheck is appropriate.
In my opinion it is proper software release strategy to create a tag anytime you release a new version of your software; that's why the portgroup continues to livecheck the tags even when downloading from a tarball. If we ever encounter a project that does not create tags, but does have download files, and we cannot convince the developers to create tags, then we can enhance the github portgroup.
proposed patch