Opened 12 years ago
Closed 12 years ago
#36470 closed defect (fixed)
py27-pygrib: error: use of undeclared identifier 'voidp'; did you mean 'void'?
| Reported by: | tylordippel@… | Owned by: | jswhit (Jeff Whitaker) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | Cc: | nerdling (Jeremy Lavergne), EJFielding (Eric Fielding), peeter.as@… | |
| Port: | py27-pygrib |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
After installing Macports, I entered sudo port install py27-pygrib. Many of the dependencies were installed; however, when it got the the py27-pygrib installer, I got an error. I installed macports with the package installer and have the xcode commend line tools installed. Here is what the log file said:
(pasted log removed by admin; see attachment)
Attachments (3)
Change History (17)
Changed 12 years ago by tylordippel@…
comment:1 Changed 12 years ago by tylordippel@…
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Description: | modified (diff) |
|---|---|
| Owner: | changed from macports-tickets@… to jswhit@… |
| Port: | py27-pygrib added |
| Priority: | High → Normal |
| Summary: | Unable to install py27-pygrib → py27-pygrib: error: use of undeclared identifier 'voidp'; did you mean 'void'? |
comment:3 Changed 12 years ago by jmroot (Joshua Root)
It should be png_voidp, and it seems to be fixed upstream.
comment:7 follow-up: 9 Changed 12 years ago by EJFielding (Eric Fielding)
As a temporary patch, I was able to get the existing pygrib 1.9.2 code to build with the change suggested by jmr above (voidp should be png_voidp). I went into the work directory of a failed build (.../py27-pygrib/work/pygrib-1.9.2) and edited these two files:
g2clib_src/dec_png.c
g2clib_src/enc_png.c
On line 91 of both files, change "voidp" to "png_voidp".
EDIT: Then just run "port install" again.
comment:8 follow-up: 10 Changed 12 years ago by jswhit (Jeff Whitaker)
This is fixed in newer versions of pygrib - so upgrading the package to use pygrib-1.9.5 will solve this issue.
comment:9 Changed 12 years ago by peeter.as@…
Replying to Eric.J.Fielding@…:
As a temporary patch, I was able to get the existing pygrib 1.9.2 code to build with the change suggested by jmr above (voidp should be png_voidp). I went into the work directory of a failed build (py27-pygrib/work/pygrib-1.9.2) and edited these two files:
g2clib_src/dec_png.c
g2clib_src/enc_png.cOn line 91 of both files, change "voidp" to "png_voidp".
Thank you for the information!
Which port commands to use to recompile after changing the source file?
EDIT. I got it installed now. I overlooked something probably.
comment:10 Changed 12 years ago by mf2k (Frank Schima)
Replying to jswhit@…:
This is fixed in newer versions of pygrib - so upgrading the package to use pygrib-1.9.5 will solve this issue.
You are the maintainer of this port, so supplying a patch would be considered part of that job.
Changed 12 years ago by jswhit (Jeff Whitaker)
new Portfile for py-pygrib (version 1.9.5)
comment:11 Changed 12 years ago by jswhit (Jeff Whitaker)
OK, here's a new Portfile. Is this the right place to submit it, or should I open a new ticket?
comment:12 Changed 12 years ago by mf2k (Frank Schima)
This ticket is fine. But please submit a unified diff of the portfile against trunk so we can see what changes you made.
comment:14 Changed 12 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Thanks! r99881.
I've also attached the log file.