Opened 12 years ago

Last modified 5 years ago

#36581 assigned enhancement

Patched portfile that allows amarok 2.4.3 to build and install

Reported by: james-mathiesen@… Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: dcecchin@…
Port: amarok

Description

The Portfile for amarok 2.3.4 does not build, at least not on my system and there seem to be a few open tickets.

The problems appeared to be small and all related to C++ namespaces.

I'm attaching a revision 4 which adds three minor patches.

Attachments (4)

patch-Portfile-2.4.3_4 (1006 bytes) - added by james-mathiesen@… 12 years ago.
Amarok 2.4.3 Revision 3 -> Revision 4
patch-utilities-afttagger-AFTTagger.cpp.diff (371 bytes) - added by james-mathiesen@… 12 years ago.
Use std::cin consistently to reference standard input
patch-src-TrayIcon.cpp.diff (748 bytes) - added by james-mathiesen@… 12 years ago.
declare qt_mac_set_dock_menu in the global namespace
patch-src-MainWindow.cpp.diff (648 bytes) - added by james-mathiesen@… 12 years ago.
declare qt_mac_set_dock_menu in the global namespace and attach main menu to tray icon

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by james-mathiesen@…

Attachment: patch-Portfile-2.4.3_4 added

Amarok 2.4.3 Revision 3 -> Revision 4

Changed 12 years ago by james-mathiesen@…

Use std::cin consistently to reference standard input

Changed 12 years ago by james-mathiesen@…

Attachment: patch-src-TrayIcon.cpp.diff added

declare qt_mac_set_dock_menu in the global namespace

Changed 12 years ago by james-mathiesen@…

declare qt_mac_set_dock_menu in the global namespace and attach main menu to tray icon

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to illogic-al@…

comment:2 Changed 12 years ago by dcecchin@…

Cc: dcecchin@… added

Cc Me!

comment:3 Changed 12 years ago by jmroot (Joshua Root)

Is any of this still needed with 2.6.0?

comment:4 Changed 12 years ago by james-mathiesen@…

i haven't tried building 2.6.0, sorry...

comment:5 Changed 5 years ago by mf2k (Frank Schima)

Owner: illogic-al@… deleted
Status: newassigned
Version: 2.1.2
Note: See TracTickets for help on using tickets.