#36591 closed defect (fixed)
qt4-mac: menu item enabling/disabling breaks
| Reported by: | cbradney@… | Owned by: | michaelld (Michael Dickens) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | haspatch | Cc: | mkae (Marko Käning) |
| Port: | qt4-mac |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
Hi
Qt 4.8.3 has a bug (https://bugreports.qt-project.org/browse/QTBUG-25544) from a regression that is Mac specific that causes menu item disabling/enabling to break. Would it be possible to include that as a patch in the 4.8.3 port prior to the 4.8.4 release (for which we don't know when that would be)?
Thanks
Craig
Attachments (1)
Change History (13)
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Description: | modified (diff) |
|---|---|
| Keywords: | haspatch added |
| Owner: | changed from macports-tickets@… to michaelld@… |
| Port: | qt4-mac added |
| Summary: | Requesting patch from Qt be applied to 4.8.3 → qt4-mac: menu item enabling/disabling breaks |
comment:2 Changed 12 years ago by michaelld (Michael Dickens)
comment:4 Changed 12 years ago by michaelld (Michael Dickens)
OK; I'll get this integrated as soon as I can get a patchfile created.
Changed 12 years ago by michaelld (Michael Dickens)
| Attachment: | patch-qt4-mac.diff added |
|---|
patch to qt4-mac 4.8.3_1 to hopefully fix menu state
comment:5 Changed 12 years ago by michaelld (Michael Dickens)
I just attached a patch that hopefully fixes this issue. Can you try it out before I commit it? I know it takes a long time to compile qt4-mac, but since I have no idea how to test this issue out and you do, I'd appreciate your trying to do so. I can provide a script if you don't know how to work within the MacPorts file layout.
comment:7 Changed 12 years ago by cbradney@…
Cool... built it and Scribus against it. What I thought was a Scribus bug is now gone.
comment:8 Changed 12 years ago by michaelld (Michael Dickens)
So, I take it that the patch works for you?
comment:10 Changed 12 years ago by michaelld (Michael Dickens)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed in r99492. I did not rev-bump qt4-mac, so you'll need to reinstall it instead of update it.
comment:11 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Specifically, you'll need to request a source-only build ("-s"), otherwise you might get a binary from our packages server that does not include this fix.
sudo port selfupdate sudo port -ns upgrade --force qt4-mac
Seems like the actual set of patches is from https://codereview.qt-project.org/#change,34175 , yes?