portpkg.tcl script fails with segfault

[damoclark (Damo)]

Like 189 of portpkg.tcl uses the findBinary procedure to locate the full path to the cpio binary and then uses that as the value to the -x parameter of the pax command. This causes pax to segmentation fault.

The command that fails is:

cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_multimedia_mythtv-core.25/mythtv-core.25/work/destroot && /bin/pax -x /usr/bin/cpio -w -z . > /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_multimedia_mythtv-core.25/mythtv-core.25/work/mythtv-core.25-0.25.2-Fixes-20120918.pkg/Contents/Archive.pax.gz

The attached patch file simply uses 'cpio' as the parameter to -x option of pax rather than the calculated full path (ie /usr/bin/pax). With just 'cpio' there is no segmentation fault.

[damoclark (Damo)]

Patch to portpkg.tcl setting the archive format to 'cpio' rather than '/usr/bin/cpio'

[damoclark (Damo)]

Sorry, I should have added that this was on OSX 10.8.1 I suspect earlier versions of Mac OS had a more tolerant pax command.

Damien.

[ryandesign (Ryan Carsten Schmidt)]

Could you attach the crash log from that segmentation fault? It should be in ~/Library/Logs/DiagnosticReports

[damoclark (Damo)]

Crash log from pax command

[damoclark (Damo)]

Crash log attached. The segfault can be reproduced directly from the command line:

pax -x /usr/bin/cpio -w -z /tmp >/dev/null

If you run it without the full path, there is no segfault:

pax -x cpio -w -z /tmp >/dev/null

This is on 10.8.1. Both the above commands work fine on 10.7.5.

[jmroot (Joshua Root)]

This was already fixed in r96262. You can't hit the problematic code if you have PackageMaker installed, BTW.