Opened 12 years ago

Closed 12 years ago

#36952 closed submission (fixed)

libstemmer port

Reported by: dave@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: Cc:
Port: libstemmer

Description

See attached portfile. I suggest putting it under textproc

Attachments (2)

Portfile (1010 bytes) - added by dave@… 12 years ago.
Portfile.2 (1.4 KB) - added by dave@… 12 years ago.
Fixed version of Portfile

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by dave@…

Attachment: Portfile added

comment:1 Changed 12 years ago by dave@…

Sorry; pls delete the top line of the attachment.

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Port: libstemmer added

Thanks! Some initial comments:

  • The "revision" line must be a non-negative integer and should start at 0 and increase by 1 anytime a change is made to the portfile that results in changing the files that get installed but that does not also include changing the version (which is when you would reset the revision to 0).
  • The "long_description" line is missing.
  • The "license" line is missing. According to the project's web page, this software is under the BSD license, so the line should read "license BSD".

The previous three items are covered by the output of "port lint", which you should run before submitting portfiles:

$ port lint
--->  Verifying Portfile for libstemmer
Error: Missing required variable: long_description
Error: Port revision is not numeric: svn-556
Warning: no license set
  • The "$Id$" line should remain, but should be the second line; the modeline should be the first. Subversion will automatically fill the correct information into the "$Id$" line when it is committed with the proper svn:keywords property set.
  • The "post-build" block should use the Tcl "move" procedure instead of calling out to the shell with "system".
  • There's no need in the "destroot" block to to make the "lib" and "include" directories manually; MacPorts makes the standard directories for you automatically.
  • Since you use "use_configure no", that means you probably need to take care of UsingTheRightCompiler and -arch flags and adding a universal variant if possible.

comment:3 Changed 12 years ago by dave@…

A fixed version is attached; thanks for the tips.

Changed 12 years ago by dave@…

Attachment: Portfile.2 added

Fixed version of Portfile

comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:5 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

I committed it in r99715 with these changes:

  • Removed "revision 0" line since that is the default.
  • Added -arch flags and universal variant.
  • Ran ranlib on the library after copying it from the object file. I don't know what all this does, but it seems to be a common thing to do, and it makes lipo -info able to know what architectures are in it, which is desirable.
  • Changed svn.url from snowball/trunk to snowball/trunk/snowball to save the time and bandwidth of downloading the other directories in trunk that we don't need.
  • Changed svn.revision from 556 to 546 since that's the latest revision of the snowball subdirectory.
  • Changed version from 0.1-556 to 0.1-20110629 since a date seems nicer than an svn revision and that's the date svn revision 546 was committed.
  • Enabled livecheck.
Note: See TracTickets for help on using tickets.