Opened 12 years ago
Closed 9 years ago
#37034 closed enhancement (fixed)
plplot: use cmake portgroup
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | tenomoto (Takeshi Enomoto) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | cooljeanius (Eric Gallager) | |
Port: | plplot |
Description
The plplot portfile could probably be simplified by using the cmake portgroup.
Change History (9)
comment:1 Changed 12 years ago by tenomoto (Takeshi Enomoto)
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
There were still a couple problems.
The cmake build dependency got removed; you probably received a buildbot failure notification about that. Fixed in r99952 by appending to, instead of overwriting, the portgroup's dependencies.
There was still some code setting the variables cflags and cxxflags, but those variables were no longer used so I removed this code in r99953.
The port still sets CMAKE_OSX_ARCHITECTURES manually, but the cmake portgroup does that for you. In fact it looks like in some cases (when the g95 variant is set and the universal variant is not set) the port wants CMAKE_OSX_ARCHITECTURES not to be set at all? If that's truly required, then I'm not sure if the cmake portgroup accommodates that need. Perhaps we can explore this further to find out why the port is doing this.
comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:4 Changed 12 years ago by tenomoto (Takeshi Enomoto)
comment:5 Changed 12 years ago by jmroot (Joshua Root)
Does setting CMAKE_OSX_ARCHITECTURES cause cmake to pass -arch flags to every compiler used? Is that correct behaviour on cmake's part?
comment:8 Changed 10 years ago by mojca (Mojca Miklavec)
Could you please check this again now that the latest versions of GCC ignore the -arch
flag?
comment:9 Changed 9 years ago by tenomoto (Takeshi Enomoto)
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Committed in r99949.