Opened 12 years ago
Closed 12 years ago
#37234 closed update (fixed)
py-request: update to 0.14.1
Reported by: | larryv (Lawrence Velázquez) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.1.2 |
Keywords: | haspatch maintainer | Cc: | saispo@… |
Port: | py-requests |
Description
Self-explanatory.
Attachments (2)
Change History (8)
Changed 12 years ago by larryv (Lawrence Velázquez)
Attachment: | Portfile-py-requests.diff added |
---|
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 12 years ago by larryv (Lawrence Velázquez)
Hm. The tarball hosted at PyPI is missing the chardet2
package, while the one at GitHub has it.
% ls requests-0.14.2-pypi/requests/packages __init__.py chardet/ oauthlib/ urllib3/ % ls requests-0.14.2-github/requests/packages __init__.py chardet/ chardet2/ oauthlib/ urllib3/
Not sure what the best course of action here is. Should we just grab the tarball from GitHub?
comment:3 follow-up: 4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|
There seems to be a bit of difference between the two requests-0.14.2s:
$ diff -ru {github,pypi}/requests-0.14.2 Only in github/requests-0.14.2: .env Only in github/requests-0.14.2: .gitignore Only in github/requests-0.14.2: .travis.yml Only in github/requests-0.14.2: AUTHORS.rst Only in github/requests-0.14.2: Makefile Only in pypi/requests-0.14.2: PKG-INFO Only in github/requests-0.14.2: docs Only in github/requests-0.14.2: ext Only in pypi/requests-0.14.2/requests: adapters.py Only in github/requests-0.14.2/requests/packages: chardet2 Only in github/requests-0.14.2/requests/packages/urllib3: contrib Only in pypi/requests-0.14.2: requests.egg-info Only in github/requests-0.14.2: requirements.txt Only in pypi/requests-0.14.2: setup.cfg Only in github/requests-0.14.2: tests
If the one from github works, I guess we should use that. My concern would be if any of the files in the pypi version that aren't in the github version are needed.
I note from the github history that chardet has already been removed from the project in favor of charade so I guess this problem will fix itself with the next release.
comment:4 Changed 12 years ago by larryv (Lawrence Velázquez)
Replying to ryandesign@…:
I note from the github history that chardet has already been removed from the project in favor of charade so I guess this problem will fix itself with the next release.
We could wait on 0.14.3. In the meantime, 0.14.1 seems to work fine, so let's at least update to that. I also added a subport for Python 3.3.
Changed 12 years ago by larryv (Lawrence Velázquez)
Attachment: | Portfile-py-requests-0.14.1.diff added |
---|
update to 0.14.1
comment:5 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… removed |
---|---|
Owner: | changed from macports-tickets@… to ryandesign@… |
Status: | new → assigned |
Summary: | py-requests @0.13.6 - update to 0.14.2 → py-request: update to 0.14.1 |
comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The py3* subports don't build: