Opened 12 years ago
Closed 12 years ago
#37245 closed defect (fixed)
qt4-mac: /opt/local/include/Qt/qxmlstream.h is a bad symbolic link
| Reported by: | ajdudman | Owned by: | michaelld (Michael Dickens) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.99 |
| Keywords: | haspatch | Cc: | |
| Port: | qt4-mac |
Description
Header qxmlstream.h exists in both QtCore and QtXml frameworks. Procedure post-destroot at Portfile line 893 finds both and thus creates a bad symbolic link at line 906. I suggest the test at line 898 should check list length instead.
Attachments (1)
Change History (4)
Changed 12 years ago by ajdudman
| Attachment: | Portfile.patch added |
|---|
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to michaelld@… |
|---|---|
| Summary: | /opt/local/include/Qt/qxmlstream.h is a bad symbolic link → qt4-mac: /opt/local/include/Qt/qxmlstream.h is a bad symbolic link |
comment:2 Changed 12 years ago by michaelld (Michael Dickens)
comment:3 Changed 12 years ago by michaelld (Michael Dickens)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Turns out all of the headers in include/Qt just #include'd the correct actual header; so, no need to replace any of them. Fixed in r100392.
Note: See
TracTickets for help on using
tickets.
Good catch. Looks like the one in QtCore is the real one. But, as your patch indicates, it's probably wiser to create the link only when there is exactly one file found. I'll get it integrated. Thanks!