Kinect support in OpenCV: openni-devel (submission), openni-devel-sensorkinect (submission), opencv (enhancement), openni (enhancement)

[josephhowse@…]

I have a set of submissions and enhancements that bring Kinect support to OpenCV.

The submissions are:

(1) openni-devel - the unstable branch of OpenNI

(2) openni-devel-sensorkinect - the SensorKinect module for the unstable branch of OpenNI.

The enhancements are to:

(1) opencv - adding a variant, +openni-devel-sensorkinect, and a modified patch file, patch-cmake-OpenCVFindOpenNI.cmake.diff. These are for compilation against openni-devel-sensorkinect.

(2) openni - adding a conflict with openni-devel because they would install conflicting dylibs.

[josephhowse@…]

graphics/openni-devel-sensorkinect/files/patch-Platform-Linux-Build-Common-CommonCppMakefile.diff

[josephhowse@…]

graphics/openni-devel-sensorkinect/files/patch-Platform-Linux-Build-Common-Platform.x86.diff

[josephhowse@…]

graphics/openni-devel-sensorkinect/files/patch-Platform-Linux-CreateRedist-install.sh.diff

[josephhowse@…]

graphics/openni/Portfile-rrdtool.diff

[josephhowse@…]

graphics/opencv/Portfile-rrdtool.diff

[cooljeanius (Eric Gallager)]

Cc Me!

[jmroot (Joshua Root)]

Adding opencv and openni maintainers to Cc. (Please remember to Cc maintainers when you create a ticket).

[ryandesign (Ryan Carsten Schmidt)]

Regarding openni-devel-sensorkinect​, the -devel suffix should go at the end (openni-sensorkinect-devel). Is there a reason why we cannot offer a stable version of this port?

The conflicts keyword takes bare port names, not dependency specifiers, so it should be "conflicts openni", etc.

Regarding the opencv patch​, we don't typically use the word "devel" in variant names; we don't typically depend on -devel ports, though we can in cases like these where no non-devel port exists. Note that we had an existing request to add an openni variant to the opencv port in #35512. Does this patch satisfy that request?

You've also marked the tbb variant as conflicting with the universal variant. We can do that; I assume you've done this because tbb does not have a universal variant. It would be better to fix the tbb port; see #35990.

Note that "rrdtool" is the name of a port. So the filename "Portfile-rrdtool.diff" shown in the guide was meant to be taken as an example in the hypothetical case where you are submitting a patch for the rrdtool port.

[josephhowse@…]

Thanks for the feedback. Here is some additional information that might address some of your comments. I'm happy to follow whatever naming convention is appropriate for the ports and variant.

SensorKinect depends on unstable versions of OpenNI (1.5.4.0, 1.5.2.7, 1.4.0.2, etc.).

Note that we had an existing request to add an openni variant to the opencv port in #35512. Does this patch satisfy that request?

we don't typically depend on -devel ports

An +openni variant was already added to opencv in a recent update. The difference between +openni_devel_sensorkinect (my submission) and the existing +openni variant is that +openni_devel_sensorkinect also supports Kinect via SensorKinect. Due to SensorKinect's dependency on an unstable OpenNI version, +openni_devel_sensorkinect depends on openni-devel, whereas +openni depends on (stable) openni.

The conflicts keyword takes bare port names, not dependency specifiers, so it should be "conflicts openni", etc.

Do you mean that "conflicts port:openni" should be "conflicts openni" (in the openni-devel Portfile)? Or is there some problem with the use of "conflicts" in "variant openni_devel_sensorkinect conflicts openni" (in the opencv patch)?

It would be better to fix the tbb port; see #35990.

If the tbb port is being fixed, then, yes, the proposed change to the opencv +tbb variant can be dropped.

[cooljeanius (Eric Gallager)]

See also issue #37320 for more on updating tbb to fix the problems with OpenCV's +tbb and +universal variants

[ryandesign (Ryan Carsten Schmidt)]

Replying to josephhowse@…:

Note that we had an existing request to add an openni variant to the opencv port in #35512. Does this patch satisfy that request?

An +openni variant was already added to opencv in a recent update.

Oh! Then I'll close that ticket.

The conflicts keyword takes bare port names, not dependency specifiers, so it should be "conflicts openni", etc.

Do you mean that "conflicts port:openni" should be "conflicts openni" (in the openni-devel Portfile)?

Yes, this is what I meant.

[josephhowse@…]

graphics/openni-sensorkinect/Portfile

[josephhowse@…]

All related Portfiles, diffs and patches

[josephhowse@…]

I've made the following changes:

1. openni-devel-sensorkinect renamed to openni-sensorkinect
2. opencv +openni_devel_sensorkinect renamed to opencv +openni_sensorkinect
3. dropped the modifications to opencv +tbb

Also, the naming scheme of diff files is corrected.

The following attachments (which appear consecutively in the attachments list, above) are the up-to-date ones:

• graphics.zip​
• Portfile-opencv.diff​
• patch-cmake-OpenCVFindOpenNI.cmake.diff​
• Portfile-openni.diff​
• Portfile​
• patch-Platform-Linux-Build-Common-CommonCppMakefile.diff
• patch-Platform-Linux-Build-Common-Platform.x86.diff​
• patch-Platform-Linux-CreateRedist-install.sh.diff​
• patch-Source-OpenNI-XnOpenNI.cpp.diff​
• Portfile.3​
• patch-Platform-Linux-Build-Common-CommonCppMakefile.3.diff
• patch-Platform-Linux-Build-Common-Platform.x86.3.diff
• patch-Platform-Linux-Build-Makefile.diff​
• patch-Platform-Linux-CreateRedist-install.sh.3.diff​

Other attachments are outdated and should be deleted by an admin.

[josephhowse@…]

graphics/opencv/Portfile-opencv.diff

[josephhowse@…]

graphics/opencv/files/patch-cmake-OpenCVFindOpenNI.cmake.diff

[josephhowse@…]

graphics/openni/Portfile-openni.diff

[josephhowse@…]

graphics/openni-devel/Portfile

[josephhowse@…]

graphics/openni-devel/files/patch-Platform-Linux-Build-Common-CommonCppMakefile.diff

[josephhowse@…]

graphics/openni-devel/files/patch-Platform-Linux-Build-Common-Platform.x86.diff

[josephhowse@…]

graphics/openni-devel/files/patch-Platform-Linux-CreateRedist-install.sh.diff

[josephhowse@…]

graphics/openni-devel/files/patch-Source-OpenNI-XnOpenNI.cpp.diff

[josephhowse@…]

graphics/openni-sensorkinect/Portfile

[josephhowse@…]

graphics/openni-sensorkinect/files/patch-Platform-Linux-Build-Common-CommonCppMakefile.diff

[josephhowse@…]

graphics/openni-sensorkinect/files/patch-Platform-Linux-Build-Common-Platform.x86.diff

[josephhowse@…]

graphics/openni-sensorkinect/files/patch-Platform-Linux-Build-Makefile.diff

[josephhowse@…]

graphics/openni-sensorkinect/files/patch-Platform-Linux-CreateRedist-install.sh.diff

[josephhowse@…]

Deleted. Ignore this file.

[josephhowse@…]

Deleted. Ignore this file.

[josephhowse@…]

Deleted. Ignore this file.

[josephhowse@…]

If anyone has the chance to review this submission soon, that would be great. I am writing an OpenCV book for Packt Publishing and I would like to instruct Mac users to install the opencv +openni_sensorkinect variant from MacPorts.

When reviewing the submission, please see my previous comment about which attachments are still current.

Thanks!

[cooljeanius (Eric Gallager)]

The update of OpenCV to 2.4.6 with r107771 could have been a good time to add these variants...

[mf2k (Frank Schima)]

This ticket has too many separate issues and is outdated. Please file separate tickets with updated portfiles for each individual submission and enhancement if you are still interested in this.