nethack @3.4.3 +x11 Build failure

[nurblieh@…]

nethack with the x11 variant selecetd fails to build, as the X11 headers can not be found.

The bug is that the build.args-appends directive in the Portfile overrides the Makefile's CFLAGS that the x11 variant patches in.

Removing the build.args-apend directive from the Portfile fixes the issue and is, largely unnecessary. (O vs O2 though...)

This is from the x11 Makefile patch,

-CFLAGS = -O -I../include
+CFLAGS = -O -I../include -I/usr/X11R6/include

This is what exists in build.args-append,

build.args-append       CFLAGS="-O2 -I../include"

So the -I/usr/X11R6/include never gets respected.

Attached is a working diff.

Xcode 4.4; Mac OS X 10.8.2

[ryandesign (Ryan Carsten Schmidt)]

We don't want to use /usr/X11R6 for X11; we want to use ${prefix} for that.

[nurblieh@…]

Ah, then potentially there is something wrong with my install or my brain. I have no X11 headers under ${prefix}. The headers do however exist under /usr/X11R6/include , which the x11 variant uses in its patch files.

My understanding is that ${prefix} expands to /opt/local in most cases. The default macports install location.

[jmroot (Joshua Root)]

Yeah, the x11 variant also needs a dependency on one or more xorg ports.

[nurblieh@…]

Replying to jmr@…:

Yeah, the x11 variant also needs a dependency on one or more xorg ports.

Ah, that makes perfect sense, thanks much. With that intel, here's another patch. Tested on my install.

Index: dports/games/nethack/Portfile
===================================================================
--- dports/games/nethack/Portfile       (revision 100595)
+++ dports/games/nethack/Portfile       (working copy)
@@ -66,6 +66,7 @@
                x11/patch-include__config.h \
                x11/patch-sys__unix__Makefile.src \
                x11/patch-sys__unix__Makefile.top
+       depends_lib-append port:xorg-libXaw
 }
 
 variant autopickup_exceptions {

[nurblieh@…]

I should mention the above patch is stand-alone. The previously attached patch is obsolete and unnecessary.

[mf2k (Frank Schima)]

r122655